969227 - Handle X-Backoff headers

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Richard Newman [:rnewman]]

Response headers from the storage and token servers are currently a heady mix of X-Weave* and X-*.

We should handle both, just in case.

https://docs.services.mozilla.com/token/apis.html#response-headers

Comment 1

[Richard Newman [:rnewman]]

Attachment: Proposed patch. v1

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 8374315 [details] [review]
Proposed patch. v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
  Hurried FxA development.

User impact if declined: 
  Partial Sync implementation.

Testing completed (on m-c, etc.): 
  Automated tests.

Risk to taking this patch (and alternatives if risky): 
  Failure to deliver expected level of quality for Fx29.

String or IDL/UUID changes made by this patch:
  None.

Nick reviewed on GitHub. Landed with tests in a-s.

https://hg.mozilla.org/integration/fx-team/rev/e624202c4fdf

Comment 3

[Richard Newman [:rnewman]]

This isn't something we can easily QA, so flagging qa- for now. If we have a chance to set up a staging token server and somehow point the client at it, then we can give it a shot, but this at least has automated tests.

Comment 4

[James Bonacci [:jbonacci]]

Well, we do have this: https://token-stage3.stage.mozaws.net
or some flavor of that depending on frequently OPs updates our TS Stage.
Will that work?

Comment 5

[Richard Newman [:rnewman]]

(In reply to James Bonacci [:jbonacci] from comment #4)
> Well, we do have this: https://token-stage3.stage.mozaws.net
> or some flavor of that depending on frequently OPs updates our TS Stage.
> Will that work?

If you have the FxA and Sync servers to go with it, so we can do a build of Firefox pointing to those URLs. Might not be wasted effort, because we can use that setup to test Bug 958900, too.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

FYI, I will wait for your tests before uplifting the patch.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e624202c4fdf

Comment 8

[Richard Newman [:rnewman]]

Drat, I accidentally checked in some non-pngcrushed resources here. Will fix.

Comment 10

[Richard Newman [:rnewman]]

https://etherpad.mozilla.org/fxa-sync-backoff-test-plan

Comment 11

[Richard Newman [:rnewman]]

Relanded images:

https://hg.mozilla.org/integration/fx-team/rev/d7f2934f2f29

Comment 12

[Richard Newman [:rnewman]]

This was tested with Services QA along with Bug 958900 and Bug 972613, Sylvestre. Please flag all three for uplift at your convenience.

Comment 13

[Richard Newman [:rnewman]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a825e6857b1f