970818 - [Downloads Manager] Any message appears when the SD card is full

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[rafael.marquez]

*Pre-requisites
Having a SD card inserted which is full and hasn't empty space

*Procedure
1. Open browser app
2. Open a webpage whitch  you can download files.
3. Download a file which has a size bigger than the empty space in the sd card.

*Actual Result
The download fails, but the user does not know what the reason. If we try other downloads they also fail.

*Expected Result
The download fails and I think a message "memory full" should be displayed to the user. 

UX. Can you tell which is the expected result?

Comment 1

[Francis Djabri [:djabber]]

Hi Rafael, 

I've specified a new notification in the case of SD card full errors in the latest spec (v0.15) - available on Box at:

https://mozilla.box.com/s/gw84uv5ykmufiec4acl3

Please let me know if you have any comments. 

Thanks, Francis

Comment 2

[rafael.marquez]

For me it's OK. This should be developed for v1.4

Comment 3

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Thanks mates

Comment 4

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Comment on attachment 8386147 [details]
Patch v1

I mostly added 2 questions but did not do a thorough review. This looks good to me though.

I trust Francisco to review and test properly, but I have too many things on my plate right now :)

Comment 5

[Cristian Rodriguez (:crdlc)]

Julien asked:

> do we need to proofread with a native english speaker?

this text was provided by UX in the wireframe, thought that was Francis

> should we remove the failed file? Or can we resume the download if the user deletes some other files?

yep, this is the idea, users can remove some files and they will resume the failed downloads

Francis, 

   Let me know if I am wrong in something answer, thx

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8386147 [details]
Patch v1

Code wise, LGTM, then it took me a while till I fill my sdcard to try it :)

But once I tried working perfectly.

Thanks Cristian!

Comment 7

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/mozilla-b2g/gaia/commit/d888061bcd1458b39e11248b9d931bb988acdbef

Comment 8

[Francis Djabri [:djabber]]

(In reply to Cristian Rodriguez (:crdlc) from comment #5)
> Julien asked:
> 
> > do we need to proofread with a native english speaker?
> 
> this text was provided by UX in the wireframe, thought that was Francis

The text looks good to me. 

> 
> > should we remove the failed file? Or can we resume the download if the user deletes some other files?
> 
> yep, this is the idea, users can remove some files and they will resume the
> failed downloads
> 
> Francis, 
> 
>    Let me know if I am wrong in something answer, thx

That's correct, thanks for checking!

Comment 9

[rafael.marquez]

Verify in master branch (v1.4). A new similar bug opened bug 981539

Comment 10

[Francesco Lodolo [:flod]]

Is there a specific reason for using "SD card" while other messages used "memory card". 
Note that you'll need a new string ID if you want to fix it at this point.