Closed Bug 971654 Opened 10 years ago Closed 10 years ago

Black area not covered by lock screen background at the bottom for non HVGA phones

Categories

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Lockscreen
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:1.4+, b2g-v1.4 fixed)

Status:
RESOLVED FIXED
Milestone:
1.4 S2 (28feb)
Project Flags:
blocking-b2g 1.4+
Tracking Flags:
Tracking Status
b2g-v1.4 --- fixed

People

(Reporter: timdream, Assigned: timdream)

References

Details

(Keywords: regression, Whiteboard: [mwcdemo2014])

Attachments

(3 files, 1 obsolete file)

2014-02-12-18-02-55.png
547.34 KB, image/png
Details
regression.jpg
111.20 KB, image/jpeg
Details
mozilla-b2g:master PR#16680
46 bytes, text/x-github-pull-request
gweng
: review+
Details | Review 
A regression caused by bug 968569, should be easy to fix.
Flags: needinfo?(gweng)
Can we get a screenshot of the problem here? Trying to understand the severity of this bug.
I'll check this next week (2/17). And maybe take screenshots to compare the before and after results.
Flags: needinfo?(gweng)
Screenshot is in my Peak phone -- will upload when I connect the phone to laptop.
blocking-b2g: --- → 1.4?
This is possible the duplicate of bug 973053. Tim will verify it.
blocking-b2g: 1.4? → 1.4+
Taken with patch ready.
Assignee: gweng → timdream
Status: NEW → ASSIGNED
Attachment #8377441 - Flags: review?(gweng)
Attachment #8377441 - Flags: review?(gweng) → review+
master: https://github.com/mozilla-b2g/gaia/commit/258ae6472bd0e87ae074a6b9b464273dc9cfc8d6
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [mwcdemo2014]
Are you sure this the correct placement? Is the statusbar not meant to be transparent on the lock screen, and overlay the background image which goes right to the top?
Reverted due to UI regressions on lockscreen (we should not have a black background for statusbar).

https://github.com/mozilla-b2g/gaia/commit/83d40ecce413514e53a3d3c0b656b69e3b5bc328

Ni for notification.
Status: RESOLVED → REOPENED
Flags: needinfo?(timdream)
Resolution: FIXED → ---
Flags: needinfo?(timdream) → needinfo?(gweng)
Flags: needinfo?(gweng)
Attached image regression.jpg — 
I'm getting this image with this background. Happens only on certain backgrounds. Is this the same bug?
(In reply to Mason Chang [:mchang] from comment #12)
> Created attachment 8382652 [details]
> regression.jpg
> 
> I'm getting this image with this background. Happens only on certain
> backgrounds. Is this the same bug?

Yes.
Comment on attachment 8382702 [details] [review]
mozilla-b2g:master PR#16680

This is 1.4+ so please give have it cut in line.

Take 2 of the patch also changes the position of the original background so we can have exact position match of two.
Attachment #8382702 - Flags: review?(gweng)
Attachment #8377441 - Attachment is obsolete: true
Comment on attachment 8382702 [details] [review]
mozilla-b2g:master PR#16680

It works fine and solved the problem, so here is the r+. Thanks Tim.
Attachment #8382702 - Flags: review?(gweng) → review+
master: https://github.com/mozilla-b2g/gaia/commit/5589204cb3fcc60dae0a4d28932ebc118f94687d

This is a CSS only patch so we cannot write testcase for it unless we have something fancy like screenshot test suite.
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
status-b2g-v1.4: --- → fixed
Target Milestone: --- → 1.4 S2 (28feb)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: