972074 - Clients send sortindex with negative values, server rejects

Status: VERIFIED FIXED

(Cloud Services Graveyard :: Server: Sync, defect)

Description

[Richard Newman [:rnewman]]

15:44:40 < rnewman> ,"id":"qXiWDK_iOC-o","sortindex":-1,"ttl":5184000}

15:44:04 < rnewman> 1392248591527ISync.CollectionITRACEIPOST body: {"failed": {"qXiWDK_iOC-o": "invalid sortindex"}, "modified": 1392248591.46, "success": ["k8c2ec4hBJUd", "A7QIcSeT4g9Q",
                    "c1gE9pk5oJO0", "TUw_O4RfoIak", "lUc-H-g-hTGW", "s_HPMDrGZEwd"]}

15:45:49 < rfkelly> rnewman: ah, so sortindex is specced to be a positive integer in 1.5
15:46:03 < rfkelly> pls file bug, we can revert that to just "an integer"

Comment 1

[Ryan Kelly [:rfkelly]]

Attachment: sync15-negative-sortindex.diff

Okies then, I guess we have to comply.

Comment 2

[Ryan Kelly [:rfkelly]]

Attachment: docs-negative-sortindex.diff

Comment 3

[Ryan Kelly [:rfkelly]]

Actually I better add a test for this...

Comment 4

[Ryan Kelly [:rfkelly]]

Attachment: sync15-negative-sortindex.diff

OK here's a better version

Comment 5

[Toby Elliott [:telliott]]

Comment on attachment 8375184 [details] [diff] [review]
sync15-negative-sortindex.diff

Review of attachment 8375184 [details] [diff] [review]:
-----------------------------------------------------------------

Not sure why we would have negative sortindexes, but if the client needs it, it happens.

Comment 6

[Richard Newman [:rnewman]]

Not sure why either, 'cept for presumably it being a default value somewhere.

Comment 7

[Ryan Kelly [:rfkelly]]

https://github.com/mozilla-services/server-syncstorage/commit/ad3ba44341af9596d3eef3bc6ecc0a32c35b741b
https://github.com/mozilla-services/docs/commit/1635e04b58e5b1f688533851d69eb1021bf94b2c

Comment 8

[Ryan Kelly [:rfkelly]]

Deployment to prod can be tracked in Bug 972113

Comment 9

[James Bonacci [:jbonacci]]

We should QA this and Bug 972113

Comment 10

[James Bonacci [:jbonacci]]

Already out there!...