972510 - Move some healthreport tests to manifests (and re-enable them and a few others)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

This patch moves a few healthreport tests to manifests now that we have a conditional for that. Also apparently these tests were accidentally disabled in bug 924463 by removing them from DIRS when they were still installed from Makefiles.

There are still a pair of tests left in the Makefiles, they're currently preprocessed and we need to sort that out (bug 968403).

This needs a run past the tryserver to make sure we didn't break these tests in the interim.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: Move some healthreport tests to manifests (and re-enable them and a few others)

Comment 2

[(not currently active) Ted Mielczarek]

https://tbpl.mozilla.org/?tree=Try&rev=eae3a6a8919b

Comment 3

[(not currently active) Ted Mielczarek]

Attachment: Move some healthreport tests to manifests (and re-enable them and a few others).

Oops, forgot to add the moz.build files I had to add back to this patch. (They're just empty.)

Comment 4

[(not currently active) Ted Mielczarek]

Looks like enabling these tests causes another browser_healthreport.js test to go perma-orange on Linux64 debug, so I'm going to disable these tests on that platform for now:
https://tbpl.mozilla.org/?tree=Try&rev=10b3d2504806

Comment 5

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/43f0ccc6c1c5

The skip-if line is a little ugly, I found a bug in the manifest expression parser. I'll fix it when I land the patch for bug 974368.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/43f0ccc6c1c5