Closed Bug 973436 Opened 11 years ago Closed 11 years ago

[settings] refactor battery panel with AMD pattern

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
1.4 S5 (11apr)

People

(Reporter: gasolin, Assigned: arthurcc)

References

Details

Attachments

(1 file, 1 obsolete file)

Link to https://github.com/mozilla-b2g/gaia/pull/18319
182 bytes, text/html
jj.evelyn
: review+
eragonj
: feedback+
Details
Overview Description: Refactor Battery panel with AMD pattern referring to https://github.com/crh0716/gaia/tree/settings2_iterative to make it modularize and more easier to maintain Steps to Reproduce: 1) run make test-perf APP=settings 2) run make test-integration APP=settings Expected Results: pass all settings test and act the same as original implementation Additional Information:
Assignee: nobody → arthur.chen
Depends on: 981510
Target Milestone: --- → 1.4 S5 (11apr)
Status: NEW → ASSIGNED
Evelyn, could you help review the patch? Feel free to let me know if you need explanations. Thanks.
Attachment #8401044 - Flags: review?(ehung)
Attachment #8401044 - Flags: feedback?(gasolin)
Comment on attachment 8401044 [details] Link to https://github.com/mozilla-b2g/gaia/pull/17913 Looks good to me. With some jsdoc would be better!
Attachment #8401044 - Flags: feedback?(gasolin) → feedback+
Comment on attachment 8401044 [details] Link to https://github.com/mozilla-b2g/gaia/pull/17913 I think it's good. Thanks Arthur. :)
Attachment #8401044 - Flags: review?(ehung) → review+
Thanks Evelyn! master: e02008a7733c78fd371813bd63ed4d450f5af715
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Revert the patch as it introduced a JavaScript error. master: 2b796700032e15c87bfeb255874f09ff50bc682d
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Evelyn, I've fixed the JavaScript error (I thought mozL10n.once is ready :( ) and added a marionette test covering the error. The other parts remain unchanged. EJ, could you help check the newly added root panel test? Thanks.
Attachment #8401044 - Attachment is obsolete: true
Attachment #8406688 - Flags: review?(ehung)
Attachment #8406688 - Flags: feedback?(ejchen)
Attachment #8406688 - Flags: review?(ehung) → review+
master: 3fd4264899c5459db2bfa2b6cc78ef7f2eef4013
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: