959053 - [settings] add marionette test for battery panel

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[[e-mail]]

add marionette test for battery panel and main page battery status

Comment 1

[[e-mail]]

Attachment: pull request redirect to github

test passed

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8359131 [details] [review]
pull request redirect to github

Thanks for the effort, Fred. Please check my github comment.

Comment 3

[[e-mail]]

Comment on attachment 8359131 [details] [review]
pull request redirect to github

fixed comments and use selector to detect checked item

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8359131 [details] [review]
pull request redirect to github

r=me. Thanks for the patch!

Comment 5

[[e-mail]]

merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/7e4feadf3086753797f4c9752723c3a19068eaec

thanks!

Comment 6

[Kevin Grandon :kgrandon]

Reverting due to failing linter on travis: https://github.com/mozilla-b2g/gaia/commit/b1047ea52b0bf4828fb2d2c607da4e86fd7c829d

Please either fix the lint problems for JShint, or update the xfail.list file and re-land.

Comment 7

[[e-mail]]

fix lint with PR https://github.com/mozilla-b2g/gaia/pull/15663 and wait for travis result

Comment 8

[[e-mail]]

reland with all green https://github.com/mozilla-b2g/gaia/commit/ecee0ca82ddac60d077d8665b5c5a3e3a1a556e6

Comment 9

[Corey Frang [:gnarf]]

In the future, please do not consider adding a file to xfail.list as a solution to jshint problems.  The solution is to fix the problems in jshint, not revert to using gjslint.

Kevin, could you kindly not suggest it as a solution next time? Fred/Arthur, can we make sure to not add more files to xfail.list? Thanks!

Comment 10

[[e-mail]]

Corey thanks for reminding.

current settings app integration test barks lots of errors in jshint.
I'd fire bug 964188 to fix it at once.