981510 - [Settings] Define the MVVM modules using AMD

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Arthur Chen [:arthurcc][inactive after 6/30]]

The MVVM modules are critical to the coming panel refactors. We should define them using AMD.

Comment 1

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/17358

Hi Evelyn, could you help review the patch? It simply separates the original files (models.js and view.js) into three files for each module. 

There are also minor changes to keyboard.js for making unit tests work. Note that this is just temporarily. Once the objects definedkeyboard.js are defined using AMD the code will not look this tricky. Which will be done in another patch.

Comment 2

[Evelyn Hung]

Comment on attachment 8393950 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/17358

Sorry for my late review. This patch is doing three things:
- separate two model objects which were defined in models.js to different files.
- wrap mvvm modules in AMD modules
- fix test cases

r+ with only one comment on the PR.

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks, Evelyn!

master: 84c7009d6efa886fbd74510203485bc4e6e2c7e6