973446 - [settings] refactor B2G improve and feedback panel with AMD pattern

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail]]

Overview Description:

Refactor B2G improve & feedback panel with AMD pattern referring to
https://github.com/crh0716/gaia/tree/settings2_iterative

to make it modularize and more easier to maintain

Steps to Reproduce:
1) run make test-perf APP=settings
2) run make test-integration APP=settings


Expected Results:

pass all settings test and act the same as original implementation

Additional Information:

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

WIP:
https://github.com/cctuan/gaia/commit/12f7e99d20b93cdc68cc6e1df5949edbb0f7e195

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

wip: unit test

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8395559 [details] [review]
PR to master

Hi Arthur,
could I have your feedback for my refactored panel?
I will write unit test for the module if you think it's ok.

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8395559 [details] [review]
PR to master

waiting for travis.

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8395559 [details] [review]
PR to master

Hi Arthur and Fred,
I've updated most of your comments.
Could you help me to check my patch?
Thanks.

Comment 6

[[e-mail]]

Comment on attachment 8395559 [details] [review]
PR to master

looks good to me, though based on EJ's patch, a more system instantiate module code style might be better. 

https://github.com/mozilla-b2g/gaia/pull/17354/files#diff-f74aacf51ebc86e4aa88b0e60eb7676bR9

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8395559 [details] [review]
PR to master

George, thanks for the patch! There are two main problems of the patch:
1. The event handlers are either not added or removed in the right function, or are not removed correctly.
2. The UI should be refreshed in the `onBeforeShow` function instead of the `init` function as the init function is called only once.

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8395559 [details] [review]
PR to master

Thanks Arthur,
patch is updated, please kindly check again.

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8395559 [details] [review]
PR to master

Great job, George! r=me with the nits addressed, thanks!

Comment 10

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks, nits are fixed and travis is green.
master: https://github.com/mozilla-b2g/gaia/commit/adde0f65383fedc3a6edf3dc5176d51d2998fdfb