957100 - [Settings] add marionette for b2g-improve and feedback page

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[(Inactive after June) George Duan [:gduan] [:喬智]]

add marionette test for b2g-improve and feedback page.

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Waiting for travis.

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8356541 [details]
PR to master

Hi Arthur,
please kindly help to check this patch for improve and feedback page in settings app.
thanks.

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8356541 [details]
PR to master

Hi Evan,

it's better to have your feedback on this marionette test. Please kindly check!
thanks.

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8356541 [details]
PR to master

Thanks for the effort! Look good to me. Please check github for a few nits. r=me.

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8356541 [details]
PR to master

Since this patch has been reviewed and Evan may have many task in queue, I clear the feedback.

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

Travis all green,
merge into master,
https://github.com/mozilla-b2g/gaia/commit/82878ba16172213cd00ba3e8b377564b290e59c1

Comment 7

[Kevin Grandon :kgrandon]

I'm sorry, we had to revert this due to multiple failing travis builds. Reverted in: https://github.com/mozilla-b2g/gaia/commit/567937b68dabc99f07ad082217b2a2a0c97762bf

Perhaps you just need to increase the timeout? Error details:

Error details: 1 failing

1) improve b2g send feedback page open email column but left it empty:

Error: timeout exceeded!

at Object.Client.waitForSync (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:679:16)

at Object.Client.waitFor (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:648:60)

at Object.MarionetteHelper.waitForElement (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-helper/index.js:131:12)

at Object.Base.waitForElement (/home/travis/build/mozilla-b2g/gaia/apps/settings/test/marionette/app/base.js:46:31)

at Object.<anonymous> (/home/travis/build/mozilla-b2g/gaia/apps/settings/test/marionette/app/regions/feedback.js:87:19)

at modifiedTest (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:644:22)

at Object.Client.waitForSync (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:669:9)

at Object.Client.waitFor (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:648:60)

at Object.FeedbackPanel.openEmailCol (/home/travis/build/mozilla-b2g/gaia/apps/settings/test/marionette/app/regions/feedback.js:86:17)

at Context.<anonymous> (/home/travis/build/mozilla-b2g/gaia/apps/settings/test/marionette/tests/improve_settings_test.js:85:21)

at Test.Runnable.run (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:211:32)

at Runner.runTest (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:372:10)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:448:12

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:297:14)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:307:7

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:245:23)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:269:7

at Hook.Runnable.run (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:213:5)

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:257:10)

at Object._onImmediate (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:274:5)

at processImmediate [as _immediateCallback] (timers.js:330:15)

make: *** [test-integration] Error 1

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

increase the search timer to 3000 ms.

Comment 10

[Evan Tseng [:evanxd]]

Test case spec for the Screen lock panel:

Send a feedback.
>> Make sure that the success message is showed.

If have any question, please discuss here.
Thanks. :)

Comment 11

[Evan Tseng [:evanxd]]

Hi all,

I cannot send the feedback on my local desktop-client.
So does the test case work?

Comment 12

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8361665 [details]
PR to master

Hi Arthur,
travis is all green, please kindly review it again, thanks.

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8361665 [details]
PR to master

Cancel the review request as it still fails.

Comment 14

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8361665 [details]
PR to master

Travis green. r=me.

Comment 15

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: 55b549bfa03d8aad91a8357287f73150b219e990