973447 - [settings] refactor Language panel with AMD pattern

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail]]

Overview Description:

Refactor Language panel with AMD pattern referring to
https://github.com/crh0716/gaia/tree/settings2_iterative

to make it modularize and more easier to maintain

Steps to Reproduce:
1) run make test-perf APP=settings
2) run make test-integration APP=settings


Expected Results:

pass all settings test and act the same as original implementation

Additional Information:

Comment 1

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master

Hi Fred & Arthur,

please give me some feedbacks so that I can make sure I am on the right way !

THanks :)

Comment 2

[[e-mail]]

Comment on attachment 8393983 [details] [review]
patch on master

looks good but could be enhanced with modern requirejs pattern

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8393983 [details] [review]
patch on master

Good work EJ!

As we are starting to come up concrete guidelines, I simply added some of my thoughts in github, and then we can discuss whether they are making sense or not. We need more practical experiences like this to make solid guidelines. :)

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks all, I would start to refactor based on your suggestions and talk with you guys with some thoughts. 

:)

Comment 5

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Forgot to take the bug

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Hi Fred & Arthur, 

how about this change !? :P

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

LGTM. Please check my comments in github.

Comment 8

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Hi Arthur, 

I think this patch is almost done ! Can you help me check again :) ? 

If there is no big problem, I think we are ready to review :)

Comment 9

[[e-mail]]

Comment on attachment 8393983 [details] [review]
patch on master

as comment in github

Comment 10

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8393983 [details] [review]
patch on master

Arthur, I think this patch is ready for review :)

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8393983 [details] [review]
patch on master

Please address my last nits (I promise) in github. Thanks! :]

Comment 12

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8393983 [details] [review]
patch on master

Arthur, I think the PR looks nice now. I would set r? on you and plz help me review this patch when you have time (I think we are almost there !!! xD)

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8393983 [details] [review]
patch on master

r=me with the last nit addressed. Thanks!

Comment 14

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Arthur Chen [:arthurcc] from comment #13)
> Comment on attachment 8393983 [details] [review]
> patch on master
> 
> r=me with the last nit addressed. Thanks!

Thanks Arthur, I would rebase the code and make sure CI is passed. :)

Comment 15

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks Arthur and Fred, just merged the code into Gaia/master : 44a0bd975ea35879a013e82ef31a33058ae5a10e