956642 - [Settings] add marionette for language change

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

We have to add a marionette test to make sure we can change language successfully.

Comment 1

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on github

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

it seems that this approach will make travis fail to run but it works on local. Have to check more details about testing environment.

Comment 3

[Evan Tseng [:evanxd]]

Test Description:
Change the "Language" item.

Expected Results:
Make sure the mozSettings value is correct.
Make sure the "Sample Format" is correct.
Make sure the label in the panel is translated.

If have any question, please discuss here.
Thanks. :)

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8356957 [details] [review]
patch on github

Hi Evan & Arthur,

can you guys help me review this :D? I just implemented all necessary tests on language panel ! Thanks ;)

Comment 5

[Evan Tseng [:evanxd]]

Comment on attachment 8356957 [details] [review]
patch on github

Hi EJ(小龍哥),

Sorry for the late reply.

There is a new rule for review process of marionette test:

Please make sure the `marionette_js_stable_check` action of the patch is passed on Travis
(https://travis-ci.org/mozilla-b2g/gaia/jobs/18937817), then you could set r? for your patch.

Thanks.

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8356957 [details] [review]
patch on github

https://travis-ci.org/mozilla-b2g/gaia/builds/19014043

Just passed 30 times tests ! Please take time to help me review code, thanks Evan :)

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8356957 [details] [review]
patch on github

I left some comments on the select part, please check them, thanks!

Comment 8

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Arthur Chen [:arthurcc] from comment #7)
> Comment on attachment 8356957 [details] [review]
> patch on github
> 
> I left some comments on the select part, please check them, thanks!

Yeah I replied on Github, can you check them later, Arthur ?!

Thanks !! :P

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8356957 [details] [review]
patch on github

r=me with the "optionValue" naming replaced. Thanks!

Comment 10

[Evan Tseng [:evanxd]]

Comment on attachment 8356957 [details] [review]
patch on github

Nice work!
Just have some little nits need to fix before we land the patch.
Thanks.

Comment 11

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks all, 

this patch got merged in Gaia/master : 898a12a6c39710b3a5e848fed06ef93bbfd4f0f7