Closed Bug 973727 Opened 7 years ago Closed 6 years ago

Unhide browser toolbar when reaching the end of the page

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 34
Tracking Status
firefox34 --- verified

People

(Reporter: rnewman, Assigned: rahul.parsani, Mentored)

References

Details

(Whiteboard: [lang=java][good second bug])

Attachments

(1 file)

A la Pocket: when you scroll all the way to the bottom of the page, particularly in Reader Mode, there's a good chance you're going to want to do something else. It feels backwards to have to scroll up some distance to get primary UI to reappear.

How about we consider unhiding the toolbar when you slam into the bottom of the page?

There are some edge cases to consider, but figured I'd raise the idea.
Flags: needinfo?(ibarlow)
I like that idea. Make it so. 

Related: (since you mentioned Reader Mode navigation) bug 871593
Flags: needinfo?(ibarlow)
Whiteboard: [shovel ready]
Chaps, please unlist yourself as mentors if you're not willing and able!
Mentor: lucasr.at.mozilla, wjohnston
Whiteboard: [shovel ready] → [lang=java][good second bug]
Attached patch 973727.patchSplinter Review
Added another if check in onPanZoomStopped to check whether the user has reached the end of the page. Updated the comment too.
Attachment #8470490 - Flags: review+
Attachment #8470490 - Flags: review+ → review?(wjohnston)
Comment on attachment 8470490 [details] [diff] [review]
973727.patch

Review of attachment 8470490 [details] [diff] [review]:
-----------------------------------------------------------------

I like this I think. Nice work. Thanks :)
Attachment #8470490 - Flags: review?(wjohnston) → review+
https://hg.mozilla.org/integration/fx-team/rev/1b0c32bc29a4
Assignee: nobody → rahul.parsani
Keywords: checkin-needed
Whiteboard: [lang=java][good second bug] → [lang=java][good second bug][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/1b0c32bc29a4
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [lang=java][good second bug][fixed-in-fx-team] → [lang=java][good second bug]
Target Milestone: --- → Firefox 34
Thanks Rahul!
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Depends on: 1055883
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.