973727 - Unhide browser toolbar when reaching the end of the page

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Richard Newman [:rnewman]]

A la Pocket: when you scroll all the way to the bottom of the page, particularly in Reader Mode, there's a good chance you're going to want to do something else. It feels backwards to have to scroll up some distance to get primary UI to reappear.

How about we consider unhiding the toolbar when you slam into the bottom of the page?

There are some edge cases to consider, but figured I'd raise the idea.

Comment 1

[Ian Barlow (:ibarlow)]

I like that idea. Make it so. 

Related: (since you mentioned Reader Mode navigation) bug 871593

Comment 2

[Richard Newman [:rnewman]]

Chaps, please unlist yourself as mentors if you're not willing and able!

Comment 3

[Rahul Parsani]

Attachment: 973727.patch

Added another if check in onPanZoomStopped to check whether the user has reached the end of the page. Updated the comment too.

Comment 4

[Wesley Johnston (:wesj)]

Comment on attachment 8470490 [details] [diff] [review]
973727.patch

Review of attachment 8470490 [details] [diff] [review]:
-----------------------------------------------------------------

I like this I think. Nice work. Thanks :)

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/1b0c32bc29a4

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1b0c32bc29a4

Comment 7

[Aaron Train [:aaronmt]]

Thanks Rahul!