974320 - [Dialer][Call waiting][Conference call] Wrong left ellipsis applied on contact name

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Germán Toro del Valle (:gtorodelvalle)]

STR:
1. Create a contact with a kind of long name. I used mine: "Germán Toro del Valle".
2. Create a second contact with another kind of a long name. I used "Guillermo Conde More".
3. Call "Germán".
4. Take the call on "Germán"'s device.
5. Click the "add call" button (phone with '+' icon :-) ).
6. Call "Guillermo".
7. Take the call on "Guillermo"'s device.

OBSERVED:
8. The first call (the one on hold) presents a wrong left ellipsis. On the other hand, the proper smaller (minimal size) font is not applied to the second call. Please, see [screenshot 1] and [screenshot 2].

EXPECTED:
8. The call group is shown applying to each of the contacts in the call the proper smaller (minimal size) font and the right ellipsis.

From that point on, the name of the first contact ("Germán") gets applied the left ellipsis everywhere. For example, if a conference call is established, in the call member list it can be seen what's depicted in [screenshot 3].
On the other hand, if the previous conference call is not established but "Guillermo" hang up the call, it can be seen what's depicted in [screenshot 4].

Comment 1

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: [screenshot 1] device-2014-02-19-110752.png

Comment 2

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: [screenshot 2] device-2014-02-19-110820.png

Comment 3

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: [screenshot 3] device-2014-02-19-110947.png

Comment 4

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: [screenshot 4] device-2014-02-19-110921.png

Comment 5

[Germán Toro del Valle (:gtorodelvalle)]

BTW, this happens in master (Gecko-47debb4.Gaia-6e71ab4). It DOES also happen in v1.3 (Gecko-0b4f0a8.Gaia-a43904d).

Need-infoing Noemí about the way to proceed regarding nominating, project flags and so on ;-) Thanks!

Comment 6

[Noemí Freire (:noemi)]

Hi,

I'd suggest to land when ready, ni to Wilfred for his consideration too. Thanks!

Comment 7

[Germán Toro del Valle (:gtorodelvalle)]

BTW, it DOES NOT reproduce in v1.2 (Gecko-bddb176.Gaia-539a25e).

Comment 9

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Ellipsis in contact names

Included additional information as provided by Jose (UX) in bug 944660 ;-)

Comment 10

[Noemí Freire (:noemi)]

Hi,
 
Attaching 2 screenshots showing the visual gap between the UX proposal and the current implementation for the following scenarios:
scenario a- call on hold + active call (existing contacts)
1. Ellipsis issue reported in https://bugzilla.mozilla.org/show_bug.cgi?id=974320#c0
2. Wrong font size
 
 
scenario b- call on hold + active call (non-existing contacts)
1. Wrong font size
2. Wrong font size
3. Wrong vertical aligment

Comment 11

[Noemí Freire (:noemi)]

(In reply to Noemí Freire (:noemi) from comment #10)
> Hi,
>  
> Attaching 2 screenshots showing the visual gap between the UX proposal and
> the current implementation for the following scenarios:
> scenario a- call on hold + active call (existing contacts)
> 1. Ellipsis issue reported in
> https://bugzilla.mozilla.org/show_bug.cgi?id=974320#c0
> 2. Wrong font size
>  
>  
> scenario b- call on hold + active call (non-existing contacts)
> 1. Wrong font size
> 2. Wrong font size
> 3. Wrong vertical aligment

Sorry, I forgot to add scenario c- conference call on hold + active call (existing & non-existing contacts)
1. Wrong font size & missing info
2. Wrong font size

Comment 12

[Noemí Freire (:noemi)]

Attachment: a- Call on hold + Active call (existing contacts)

Comment 13

[Noemí Freire (:noemi)]

Attachment: b- Call on hold + Active call (non-existing contacts)

Comment 14

[Noemí Freire (:noemi)]

Attachment: c- Conference call on hold + Active call (existing & non-existing contacts)

Comment 15

[Michael Henretty [:mikehenrty][:mhenretty]]

This was fixed as part of bug 974211.

Comment 16

[Loli (:lolimartinezcr)]

(In reply to Michael Henretty [:mhenretty] from comment #15)
> This was fixed as part of bug 974211.
> 
> *** This bug has been marked as a duplicate of bug 974211 ***

This bug isn't duplicate of 974211, because it is about left ellipsis in name of contact and 974211 is about truncate of phone number. For this reason I open this bug.

Comment 17

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Loli from comment #16)
> (In reply to Michael Henretty [:mhenretty] from comment #15)
> > This was fixed as part of bug 974211.
> > 
> > *** This bug has been marked as a duplicate of bug 974211 ***
> 
> This bug isn't duplicate of 974211, because it is about left ellipsis in
> name of contact and 974211 is about truncate of phone number. For this
> reason I open this bug.

Can you check if this still reproduces? The code from bug 974211 should have fixed this on both master and 1.3.

Comment 18

[Maria Angeles Oteo (:oteo)]

With yesterday's builds I reproduced this bug as Loli has explained in #comment16, but right now it's working fine with latest 1.3 and master builds...

Anyway, keeping ni to Loli to confirm it, as she's the QA expert ;) .

master
B-90
Gecko-ef8c288
Gaia-1ed301a

v1.3
B-91
Gecko-0216606
Gaia-9b29f80

Comment 19

[Loli (:lolimartinezcr)]

Tested
Hamachi
1.3
Platform version: 28.0
Build identifier:20140306111624
Git commit: 8ead4faf

1.4
Gecko: 73e3265
Gaia: e5f072a