974731 - Failing calendar marionette test create_event_test.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Kevin Grandon :kgrandon]

This was disabled in bug 919066, then un-disabled but never fully tested-ran. Please run a minimum of 50 times before landing again.

1) creating an event "before each" hook:

Error: timeout exceeded!

at Object.Client.waitForSync (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:679:16)

at Object.Client.waitFor (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:648:60)

at Object.Calendar.waitForMonthView (/home/travis/build/mozilla-b2g/gaia/apps/calendar/test/marionette/calendar.js:125:17)

at Context.<anonymous> (/home/travis/build/mozilla-b2g/gaia/apps/calendar/test/marionette/create_event_test.js:36:9)

at Hook.Runnable.run (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:211:32)

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:257:10)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:269:7

at done (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:185:5)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:197:9

at Object.executeHook (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:370:18)

at process._tickCallback (node.js:415:13)

Comment 1

[Gareth Aye [:gaye] (back from PTO)]

kgrandon you will find this funny https://travis-ci.org/mozilla-b2g/gaia/builds/20557989

Comment 2

[Kevin Grandon :kgrandon]

Amazing.

Comment 3

[Miller Medeiros [:millermedeiros]]

talked with Gareth on IRC. I did not test it, but based on the code I would investigate the `app.createEvent()` method. The code that checks if view is active looks for the `body[data-path]` and if the view element contains the class `.active`; the only way I can see that happening is if the `this.waitForElement('editEventSaveButton').click()` did not actually click the proper element or somehow the click got "lost" (maybe thread was blocked?)

suggestion to help debug it is to add some `console.log` to `calendar._isElementActive` and `calendar._isPath` to see what are the returned values. `body[data-path]` is supposed to always be in sync with the current view.

Comment 4

[Gareth Aye [:gaye] (back from PTO)]

I've ran the setup block that timed out 750 times and it has only failed once, so I'm going to go ahead and re-enable. I think this is permissibly flaky, but let's keep an eye on it if these pop up again.

Comment 5

[Gareth Aye [:gaye] (back from PTO)]

(750 times on travis that is)

Comment 6

[Gareth Aye [:gaye] (back from PTO)]

https://github.com/mozilla-b2g/gaia/commit/b5d0f9b0cd5dce38b79287a9363226b912929270

Comment 7

[Kevin Grandon :kgrandon]

I'm not sure if it's this bug, or the refactor, but I've seen this fail ~twice over the last two days. If it fails again we should disable it.

 1) creating an event opening event in read view should display the created event in read view:

+ expected - actual

+03/25/2014

-03/26/2014

expected '03/26/2014' to equal '03/25/2014'

Comment 8

[Gareth Aye [:gaye] (back from PTO)]

Thanks for pointing this out I'll take a look tomorrow

Comment 9

[Kevin Grandon :kgrandon]

More failures, so disabling this test for now.

1) creating an event opening event in read view should display the created event in read view:

expected '' to equal 'Puppy Bowl dogefortlongtextfotestloremipsumdolorsitamet'

Disabled in master: https://github.com/mozilla-b2g/gaia/commit/6f196637a5090a5c5e517a48e2a20bf5871b451d

Comment 10

[Miller Medeiros [:millermedeiros]]

maybe related to https://bugzilla.mozilla.org/show_bug.cgi?id=988079 ?

Comment 11

[Evan Tseng [:evanxd]]

Attachment: Pull request

Comment 12

[Miller Medeiros [:millermedeiros]]

since I'm already working on other marionette tests I'll go ahead and fix this one as well. That way Evan can write the new tests for Bug 963394 as soon as possible and we can hopefully land it till Friday.

Comment 13

[Miller Medeiros [:millermedeiros]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20036

this should be pretty stable, executed 80+ times on Travis before doing the PR. see: https://travis-ci.org/millermedeiros/gaia/builds/26799663 (each TRY == 20 runs)

Comment 14

[Miller Medeiros [:millermedeiros]]

landed into master! https://github.com/mozilla-b2g/gaia/commit/a88fa01e4c42736472a84159a7cf99c3420ececc

Comment 16

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Guess we need to uplift this patch to v2.0 to make TBPL aurora branch happy,
https://tbpl.mozilla.org/?tree=Mozilla-Aurora&showall=1&jobname=gaia-integration.

Comment 17

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Seems this test also failed on v2.0,
https://travis-ci.org/mozilla-b2g/gaia/jobs/28912215

Miller, do you think the failure above could be fixed by uplifting the patch?
Thanks.

Comment 18

[Miller Medeiros [:millermedeiros]]

Rudy, it's a different problem. Julien reported it today as well: https://bugzilla.mozilla.org/show_bug.cgi?id=1033232