Closed Bug 975381 Opened 11 years ago Closed 11 years ago

Use DOM_VK_RETURN/NS_VK_RETURN instead of DOM_VK_ENTER/NS_VK_ENTER

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 31.0

People

(Reporter: aryx, Assigned: aryx)

References

Details

Attachments

(7 files, 2 obsolete files)

calendar, v1 [checkin: comment 16]
2.87 KB, patch
Fallen
: review+
Details | Diff | Splinter Review
im, v1 [checkin: comment 16]
10.79 KB, patch
florian
: review+
Details | Diff | Splinter Review
suite/browser/, v1 [checkin: comment 16]
1.17 KB, patch
iannbugzilla
: review+
Details | Diff | Splinter Review
suite/common/, v1 [checkin: comment 16]
2.34 KB, patch
iannbugzilla
: review+
Details | Diff | Splinter Review
suite/mailnews/, v1 [checkin: comment 16]
2.65 KB, patch
iannbugzilla
: review+
Details | Diff | Splinter Review
mail, v2, r=mkmelin
3.47 KB, patch
Details | Diff | Splinter Review
mozmill, v2, r=mkmelin
2.09 KB, patch
Details | Diff | Splinter Review
Bug 969247 removed DOM_VK_ENTER/NS_VK_ENTER. DOM_VK_RETURN/NS_VK_RETURN should be used instead.
Comment on attachment 8379752 [details] [diff] [review] im, v1 [checkin: comment 16] Thanks!
Attachment #8379752 - Flags: review?(florian) → review+
Comment on attachment 8379750 [details] [diff] [review] calendar, v1 [checkin: comment 16] Thanks for the patch, r=philipp
Attachment #8379750 - Flags: review?(philipp) → review+
Comment on attachment 8379756 [details] [diff] [review] suite/browser/, v1 [checkin: comment 16] r=me, thanks
Attachment #8379756 - Flags: review?(iann_bugzilla) → review+
Comment on attachment 8379757 [details] [diff] [review] suite/common/, v1 [checkin: comment 16] r=me, thanks
Attachment #8379757 - Flags: review?(iann_bugzilla) → review+
Comment on attachment 8379758 [details] [diff] [review] suite/mailnews/, v1 [checkin: comment 16] r=me, thanks
Attachment #8379758 - Flags: review?(iann_bugzilla) → review+
Depends on: 969247
Since these are independent of each other, maybe we can checkin the patches that already have r+ to avoid further duplicates as far as possible?
Keywords: checkin-needed
Attachment #8379750 - Attachment description: calendar, v1 → calendar, v1 [checkin: comment 16]
Attachment #8379752 - Attachment description: im, v1 → im, v1 [checkin: comment 16]
Attachment #8379756 - Attachment description: suite/browser/, v1 → suite/browser/, v1 [checkin: comment 16]
Attachment #8379757 - Attachment description: suite/common/, v1 → suite/common/, v1 [checkin: comment 16]
Attachment #8379758 - Attachment description: suite/mailnews/, v1 → suite/mailnews/, v1 [checkin: comment 16]
mkmelin, maybe you could check the remaining TB files if mconley is away for too long :)
Flags: needinfo?(mkmelin+mozilla)
Comment on attachment 8379753 [details] [diff] [review] mail, v1 Review of attachment 8379753 [details] [diff] [review]: ----------------------------------------------------------------- Stealing this review. r=mkmelin
Attachment #8379753 - Flags: review?(mconley) → review+
Attachment #8379754 - Flags: review?(mconley) → review+
Flags: needinfo?(mkmelin+mozilla)
Keywords: checkin-needed
Whiteboard: [check in patches mozmill and mail]
https://hg.mozilla.org/comm-central/rev/50a6de9d6eaf https://hg.mozilla.org/comm-central/rev/b24fd4b3bd36
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [check in patches mozmill and mail]
Target Milestone: --- → Thunderbird 31.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: