975381 - Use DOM_VK_RETURN/NS_VK_RETURN instead of DOM_VK_ENTER/NS_VK_ENTER

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bug 969247 removed DOM_VK_ENTER/NS_VK_ENTER. DOM_VK_RETURN/NS_VK_RETURN should be used instead.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: calendar, v1 [checkin: comment 16]

https://tbpl.mozilla.org/?tree=Thunderbird-Try&showall=1&rev=a31f03fcb5e0

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: im, v1 [checkin: comment 16]

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: mail, v1

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: mozmill, v1

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: suite/browser/, v1 [checkin: comment 16]

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: suite/common/, v1 [checkin: comment 16]

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: suite/mailnews/, v1 [checkin: comment 16]

Comment 8

[Florian Quèze [:florian]]

Comment on attachment 8379752 [details] [diff] [review]
im, v1 [checkin: comment 16]

Thanks!

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8379750 [details] [diff] [review]
calendar, v1 [checkin: comment 16]

Thanks for the patch, r=philipp

Comment 10

[Ian Neal]

Comment on attachment 8379756 [details] [diff] [review]
suite/browser/, v1 [checkin: comment 16]

r=me, thanks

Comment 11

[Ian Neal]

Comment on attachment 8379757 [details] [diff] [review]
suite/common/, v1 [checkin: comment 16]

r=me, thanks

Comment 12

[Ian Neal]

Comment on attachment 8379758 [details] [diff] [review]
suite/mailnews/, v1 [checkin: comment 16]

r=me, thanks

Comment 15

[aleth [:aleth]]

Since these are independent of each other, maybe we can checkin the patches that already have r+ to avoid further duplicates as far as possible?

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/e4e8cb6ade8b
https://hg.mozilla.org/comm-central/rev/e78cda038ecc
https://hg.mozilla.org/comm-central/rev/4653c492f0d1
https://hg.mozilla.org/comm-central/rev/48a7d8a8d681
https://hg.mozilla.org/comm-central/rev/ec45d32bc405

Comment 17

[:aceman]

mkmelin, maybe you could check the remaining TB files if mconley is away for too long :)

Comment 18

[Magnus Melin [:mkmelin]]

Comment on attachment 8379753 [details] [diff] [review]
mail, v1

Review of attachment 8379753 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing this review. r=mkmelin

Comment 19

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: mail, v2, r=mkmelin

Comment 20

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: mozmill, v2, r=mkmelin

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/50a6de9d6eaf
https://hg.mozilla.org/comm-central/rev/b24fd4b3bd36