975971 - [keyboard refactor] Convert input_field.js/autocorrect.js/shiftkey.js to instantiable pattern

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

+++ This bug was initially created as a clone of Bug #975970 +++

We need input_field.js to be instantiable and started by another module.

Also jsdoc + unit test improvement wanted.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

WIP

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

It looks like these 3 files have dependency that must be fixed together.

Comment 3

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#16608

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8381327 [details] [review]
mozilla-b2g:master PR#16608

I didn't complete all JSDocs nor jshint check because I later realized we need to turn it on in pre-commit hook explicitly, so I will do it later in another pass.

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8381327 [details] [review]
mozilla-b2g:master PR#16608

r+ with some nits need to be addressed.

Tim, thanks.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8381327 [details] [review]
mozilla-b2g:master PR#16608

Test cases fixed and review comment addressed.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8381327 [details] [review]
mozilla-b2g:master PR#16608

I am going to land this so work could continue on bug 975966.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/7a3761a371f69b8bffd98de4ee4d7fd87bccaa8e