Closed Bug 976090 Opened 6 years ago Closed 2 years ago

[RIL][DSDS] We need a "lastIccId" on the thread object

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:-)

RESOLVED WONTFIX
blocking-b2g -

People

(Reporter: julienw, Unassigned)

References

Details

Bug 976089 has been created to implement https://bug947140.bugzilla.mozilla.org/attachment.cgi?id=8374261 but we need some Gecko support for this.
Flags: needinfo?(btseng)
Currently, we didn't save iccId info to each message thread.
We would like to know in detail what "lastIccId" means for a thread:
1. Will it only be identified when a incoming message is stored?
2. Or even a outgoing message is created and bound to the thread, we have to treat the iccId of that outgoing message as the lastIccId of this thread?
3. For outgoing message, how can we decide the lastIccId if the last message of the thread is a draft or a message that was failed to sent?
Flags: needinfo?(btseng) → needinfo?(felash)
Since this bug blocks DSDS feature, this bug is supposed to be fixed before 3/17, right?
Flags: needinfo?(joechengla)
(In reply to Bevis Tseng [:bevistseng] (btseng@mozilla.com) from comment #1)
> Currently, we didn't save iccId info to each message thread.
> We would like to know in detail what "lastIccId" means for a thread:
> 1. Will it only be identified when a incoming message is stored?
> 2. Or even a outgoing message is created and bound to the thread, we have to
> treat the iccId of that outgoing message as the lastIccId of this thread?
> 3. For outgoing message, how can we decide the lastIccId if the last message
> of the thread is a draft or a message that was failed to sent?

All these are very valid questions, it made me read the spec for real ;)

Following the spec https://bug947139.bugzilla.mozilla.org/attachment.cgi?id=8368585 page 6, the lastIccId is only set when the thread is unread. In that case, this is the iccId of the latest unread message.

(In reply to Ken Chang[:ken] from comment #2)
> Since this bug blocks DSDS feature, this bug is supposed to be fixed before
> 3/17, right?

Or Bug 976089 can be dropped out of 1.4.
Flags: needinfo?(felash)
(In reply to Julien Wajsberg [:julienw] from comment #3)
> (In reply to Bevis Tseng [:bevistseng] (btseng@mozilla.com) from comment #1)
> > Currently, we didn't save iccId info to each message thread.
> > We would like to know in detail what "lastIccId" means for a thread:
> > 1. Will it only be identified when a incoming message is stored?
> > 2. Or even a outgoing message is created and bound to the thread, we have to
> > treat the iccId of that outgoing message as the lastIccId of this thread?
> > 3. For outgoing message, how can we decide the lastIccId if the last message
> > of the thread is a draft or a message that was failed to sent?
> 
> All these are very valid questions, it made me read the spec for real ;)
> 
> Following the spec
> https://bug947139.bugzilla.mozilla.org/attachment.cgi?id=8368585 page 6, the
> lastIccId is only set when the thread is unread. In that case, this is the
> iccId of the latest unread message.
> 

As far as the API is concerned, you can always put the last iccId even if the thread is not unread.

How about a "lastReceivedIccId" that would take the iccId of the latest message, if it's a received message? (that means: if there is a more recent message that is "sent", don't set the lastReceivedIccId).

What do you think?
(In reply to Julien Wajsberg [:julienw] from comment #3)
> 
> Or Bug 976089 can be dropped out of 1.4.
I don't see 976089 is in key features list of 1.4, https://wiki.mozilla.org/B2G/Roadmap#Key_Focus_1.4_Features.
I am going to ask Bevis to focus on the other critical bug. If it doesn't make sense for you, please let me know.
Flags: needinfo?(joechengla)
It's fine to me, just make sure everyone agrees on this. I filed Bug 976089 because it was in the UX Spec and was not filed before, and that's probably why it's not in the Wiki. I don't especially want it either.
remove dependencies for 1.4
Put this bug into backlog.
blocking-b2g: --- → backlog
blocking-b2g: backlog → -
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.