976416 - [FDN] Add "+" character to the keypad when entering numbers in FDN list

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Enpei]

Attachment: time stamp: 11:50, 2/25.

Unable to send a SMS to number already saved in FDN list. I've also tried with the same SIM card on Android 4.4.2, 2.3.6 phones but also cannot send out SMS. But some discussion searched on Google that SMS should still be sent as long as the number is in FDN list. Please let me know what else setting should be added before make it work. (Already try add SMSC number in FDN list as well, but only in "09xxxxxxxx" format, not "+xxx9xxxxxx" due to there is no "+" in keypad.

* Build Number  
Buri
Gaia      ffb527b84594396ed611edf0a8a5a130d60a742f                  
Gecko     https://hg.mozilla.org/mozilla-central/rev/31113754db3b        
BuildID   20140223160201                                            
Version   30.0a1  

* Reproduce Steps
1. Add number 0958028270 into FDN list.
2. Go to Message, trying to send a SMS to that number.

* Expected Result
As long as the number is within FDN list, SMS can still be sent to it.

* Actual Result
FDN Active message pops up saying the number is not in FDN list while it is.

* Occurrence rate
100%

Comment 1

[Enpei]

Hi Kaze,

Do you know how we can send a SMS to number saved in FDN list? Information from other website(ex: http://www.nokia.com/us-en/support/faq/?action=singleTopic&topic=FA118979) shows that it should work as long as FDN includes the number. I wonder if I miss any step to make it work.

Thanks.

Comment 2

[Fabien Cazenave [:kaze]]

I confirm, we have a very bad issue here. Investigating.

Comment 3

[Fabien Cazenave [:kaze]]

I can reproduce this issue with my French Orange SIM card.

Comment 4

[J Zimbrick]

This can also be reproduced on a Buri device using a US AT&T SIM.

Environmental Variables:
Device: Buri 
BuildID: 20140226004002
Gaia: da50b2b62ed96993cf4df22e3d69c435b28506bd
Gecko: 3c39d1e487d9
Version: 28.0
Base Image: V1.2-device.cfg

I'll look in to the regression window.

Comment 5

[J Zimbrick]

This can be reproduced on the latest 1.2 and the latest 1.4.

I also checked for this issue on what I believe to be the earliest build where FDN became available as a feature in 1.2 (according to this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=888912) and can reproduce the issue exactly as stated in comment 0.

This issue doesn't appear to be a regression, it just hasn't worked properly since FDN was implemented (unless it could possibly be affected by the base image?).

Earliest FDN Build Environmental Variables:
Device: Buri 
BuildID: 20131213040203
Gaia: 390b313a254a947d12e3cdbcde19d7d1619ff63c
Gecko: 8b5875dc7e31
Version: 29.0a1
Base Image: V1.2-device.cfg

Latest 1.2 Environmental Variables:
Device: Buri
BuildID: 20140226004001
Gaia: 539a25e1887b902b8b25038c547048e691bd97f6
Gecko: cd18af7e5d9f
Version: 26.0
Base Image: V1.2-device.cfg

Latest 1.4 Environmental Variables:
Device: Buri
BuildID: 20140226040201
Gaia: 80d6405725788327102cab36e8d8c017cf25fb23
Gecko: 626d99c084cb
Version: 30.0a1
Base Image: V1.2-device.cfg

Comment 6

[Fabien Cazenave [:kaze]]

I’ve just been able to send an SMS in FDN mode by adding the number of the SMS call center to the FDN list (= [phone] for my French Orange SIM card).

Are mobile operators supposed to add this number to the SIM card FDN list by default? If not, how are we supposed to handle this case? I don’t even find this number in the AOSP database…

José Antonio, any idea?

Comment 7

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Fabien Cazenave [:kaze] from comment #6)
> I’ve just been able to send an SMS in FDN mode by adding the number of the
> SMS call center to the FDN list (= [phone] for my French Orange SIM
> card).
> 
> Are mobile operators supposed to add this number to the SIM card FDN list by
> default? If not, how are we supposed to handle this case? I don’t even find
> this number in the AOSP database…
> 
> José Antonio, any idea?

Sadly I have no idea. I forwarded the question to a college of mine so I'll get back to you as soon as he reply.

Comment 8

[Beatriz Rodríguez [:brg]]

(In reply to Fabien Cazenave [:kaze] from comment #6)
> I’ve just been able to send an SMS in FDN mode by adding the number of the
> SMS call center to the FDN list (= [phone] for my French Orange SIM
> card).
> 
Yes, this is the correct behaviour, both destination number and SMSC must be added to FDN list manually by the user.
> Are mobile operators supposed to add this number to the SIM card FDN list by
> default? If not, how are we supposed to handle this case? I don’t even find
> this number in the AOSP database…
> 
No, users do it manually.

> José Antonio, any idea?
Thanks for the ping here!

I think we can close this bug as INVALID. Please reopen if you feel otherwise.

Comment 9

[Noemí Freire (:noemi)]

Per comment 8, clearing v1.3+ flag

Comment 10

[Fabien Cazenave [:kaze]]

Thanks Beatriz!

Comment 11

[Fabien Cazenave [:kaze]]

That being said, the error message is misleading when the recipient number /is/ in the FDN list:

“FDN active
FDN is enabled and the following recipient is not in your FDN list: 06xxxxxxxx”

We probably could do better here. Either with a more generic message, like:

“FDN is enabled. Make sure the SMSC and all your recipients are in your FDN list.”

Or, we could check the FDN list, keep the same message when we find out the recipient is not in the FDN list, and display another message when the issue is likely to be caused by the SMSC:

“FDN is enabled. Please add the SMSC number to your FDN list.”

(In reply to Enpei from comment #0)
> (Already try add SMSC number in FDN list as well, but only in "09xxxxxxxx" 
> format, not "+xxx9xxxxxx" due to there is no "+" in keypad.

This was the missing part: I had to use the +xx format to make it work.
This is easy to fix and should be fixed ASAP.

Comment 12

[Beatriz Rodríguez [:brg]]

(In reply to Fabien Cazenave [:kaze] from comment #11)
> That being said, the error message is misleading when the recipient number
> /is/ in the FDN list:
> 
> “FDN active
> FDN is enabled and the following recipient is not in your FDN list:
> 06xxxxxxxx”
> 
> We probably could do better here. Either with a more generic message, like:
> 
> “FDN is enabled. Make sure the SMSC and all your recipients are in your FDN
> list.”
> 
> Or, we could check the FDN list, keep the same message when we find out the
> recipient is not in the FDN list, and display another message when the issue
> is likely to be caused by the SMSC:
> 
> “FDN is enabled. Please add the SMSC number to your FDN list.”
> 
IMHO, this is a nice improvement, not a blocker. Shall we open a new bug as followup and ask UX feedback?
> (In reply to Enpei from comment #0)
> > (Already try add SMSC number in FDN list as well, but only in "09xxxxxxxx" 
> > format, not "+xxx9xxxxxx" due to there is no "+" in keypad.
> 
> This was the missing part: I had to use the +xx format to make it work.
> This is easy to fix and should be fixed ASAP.

Yes, please add the + character in the keypad in order to avoid issues during certification process. Nice to here it is easy to fix.
Reopening the bug and nominating accordingly.

Comment 13

[Fabien Cazenave [:kaze]]

Attachment: link to pull request

Comment 14

[Fabien Cazenave [:kaze]]

I’ve just opened a follow-up to fix the message, see bug 978130.

Comment 15

[Fabien Cazenave [:kaze]]

Merged on master: https://github.com/mozilla-b2g/gaia/commit/b3b02fa1c9a873bd1bb3d49e8832cdf69b6ebb95

Comment 16

[Fabien Cazenave [:kaze]]

Comment on attachment 8383756 [details] [review]
link to pull request

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): ?
[User impact] if declined: user cannot send SMS in FDN mode (or add any prefixed number to the FDN list)
[Testing completed]: manual
[Risk to taking this patch] (and alternatives if risky): none — trivial patch
[String changes made]: none

Comment 17

[Noemí Freire (:noemi)]

Modifying the summary to reflect the fix gathered within this bug. Thanks!

Comment 18

[Ryan VanderMeulen [:RyanVM]]

v1.3: a0139aed141dbd0185f2106cb895876ac5145589

Comment 19

[Enpei]

Verified on Fugu

Fugu
Gaia      6781459a49642ca0eb7ec3e95667808d5d77b656
Gecko     d574219c44f75c9dfb007274e9de0479ef51020a
BuildID   20140305053055
Version   30.0a1