978130 - [FDN] Misleading message when trying to send an SMS in FDN mode

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Fabien Cazenave [:kaze]]

Following bug 976416: when FDN is enabled, SMS/MMS can’t be sent unless the recipient number *and* the SMSC are in the FDN list — in which case the user get this message:

  “FDN active
  FDN is enabled and the following recipient is not in your FDN list: 06xxxxxxxx”

… which is very confusing when the recipient number /is/ in the FDN list. I can think of two ways to do this better.

1/ Lazy way, using a more generic message, like:

  “FDN is enabled. Make sure the SMSC and all your recipients are in your FDN list.”

2/ Smarter way: we could check the FDN list, keep the same message when we find out the recipient is not in the FDN list, and display another message when the issue is likely to be caused by the SMSC.

  “FDN is enabled. Please add the SMSC number to your FDN list.”

Some UX help would be appreciated here.

Comment 1

[Fabien Cazenave [:kaze]]

Proposing 1.4? because the lack of a proper message lets most users think that SMS are broken in FDN mode.

Comment 2

[Stephany Wilkes]

Flagging Ayman to clarify behavior and Wilfred for Comms backlog consideration.

Comment 3

[Wilfred Mathanaraj [:WDM]]

i think this is critical to be addressed and we should look at fixing this. I would go with option 1. 

  “FDN is enabled. Make sure the SMSC and all your recipients are in your FDN list.”

leaving the 1.4? as we may do this in the stabilization period for v1.4.

Comment 4

[Julien Wajsberg [:julienw]]

Wilfred, remember that the strings are to be sent to the l10n localizers, so the earliest the better :)

I'd like that we do Bug 963875 in the same time (maybe in 2 different patches) because that's in the same area.

Comment 5

[Wilfred Mathanaraj [:WDM]]

if its too late at that point then this is something that needs to be done in v1.5 - specially if we are having two patches we can make the decision on the path forward now and address this in v1.5

Comment 6

[Fabien Cazenave [:kaze]]

Attachment: link to pull request

Here’s a simple fix with this message:

  FDN active

  FDN is enabled. Make sure the SMS call center and
  the following recipients are in your FDN list:
  06xxxxxxxx

This is a bit closer to our current message, and (hopefully) a bit more clear. Waiting for UX feedback before asking for a review.

Comment 7

[Noemí Freire (:noemi)]

(In reply to Fabien Cazenave [:kaze] from comment #6)
> Created attachment 8384898 [details] [review]
> link to pull request
> 
> Here’s a simple fix with this message:
> 
>   FDN active
> 
>   FDN is enabled. Make sure the SMS call center and
>   the following recipients are in your FDN list:
>   06xxxxxxxx
> 
> This is a bit closer to our current message, and (hopefully) a bit more
> clear. Waiting for UX feedback before asking for a review.

Hi Fabien,

Thanks a lot for the patch, just adding 2 minor comments:
1- The list of recipients will show the corresponding numbers such as they've been introduced by the user, right?. I mean starting with "06" is just an example.
2- We'd suggest to use just "SMS center" to refer to SMSC

Comment 8

[Fabien Cazenave [:kaze]]

> 1- The list of recipients will show the corresponding numbers such as
> they've been introduced by the user, right?. I mean starting with "06" is
> just an example.

Right.

> 2- We'd suggest to use just "SMS center" to refer to SMSC

OK, patch updated. Thanks!

Comment 9

[ayman maat :maat]

kaze is it possible to distinguish between the number for the SMS centre and regular contact numbers in the FDN list? ...or are they all treated the same?

Comment 10

[ayman maat :maat]

Hi Kaze

1) FDN is enabled and SMSC is present in list 

1.1) Behaviour when sending to a single number not in FDN list:

      FDN Active
      FDN is enabled and the following recipient is not in your FDN list:
      <phone number>

…this is the current behaviour and from a UX PoV we should avoid regressing from here by loosing the phone number

1.2) Behaviour when sending to more than one number and all numbers are not in FDN list:

      FDN Active
      FDN is enabled and the following recipients are not in your FDN list:
      <phone number>
      <phone number>

…this is the current behaviour and from a UX PoV we should avoid regressing from here by loosing the phone numbers

1.3) Behaviour when sending to two numbers: one number is in the FDN list, and one number number is not in FDN list:

we have unexpected behaviour here and have just opened up bug 979823 where we can discuss further


2) FDN is enabled but SMSC is not present in list

2.1) Desired behaviour when sending to a single number that is in FDN list: 

      FDN Active
      FDN is enabled however your SMS Center number is not in your FDN list

2.2) Desired behaviour when sending to a single number that is not in FDN list: 

      FDN Active
      FDN is enabled however your SMS Center number and the following recipient is not in your FDN list:
      <phone number>

2.2) Desired behaviour when sending to more than one number and all numbers are not in FDN list: 

      FDN Active
      FDN is enabled however your SMS Center number and the following recipients are not in your FDN list:
      <phone number>
      <phone number>

2.3) Behaviour when sending to two numbers: one number is in the FDN list, and one number number is not in FDN list:

This will be addressed in bug 979823 

Leaving Ni? to Kaze to feed back on this

...I would also point out that the dialogues for informing the user that FDN is active are very different both in information delivery and visual treatment between the Dialler and the Messages app. We should align these for consistency and continuity of UX across the platform. opened bug 979833 to address this.

Comment 11

[Beatriz Rodríguez [:brg]]

From certification point of view, we just need a more generic message such as:
  “FDN is enabled. Make sure the SMS center and all your recipients are in your FDN list.”

No need to specify the list of recipients nor smsc.

Comment 12

[David Scravaglieri [:scravag]]

Blocking but fix should be to provide a generic message, to be checked with Pike for l10n timeframe

Comment 14

[Axel Hecht [:Pike]]

We shouldn't plan to do string work after March 17. There's going to be enough churn by the things we'll only find then.

Comment 15

[Joe Cheng [:jcheng] (please needinfo)]

set target milestone to 1.4 S4 for now

Comment 16

[David Scravaglieri [:scravag]]

Sergi please could you work on this one ?

Comment 17

[Joe Cheng [:jcheng] (please needinfo)]

Sergi, will you be working on this in 1.4 S5? if so, can you move this to 1.4 S5? Thanks

Comment 18

[Axel Hecht [:Pike]]

Hard string freeze is today, fyi.

Comment 19

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Hi, I'll pick it up.

Comment 20

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Hi, as far as I see Kaze's patch basically solves the issue, right? It has been decided to not implement the more complex solution that Ayman proposes but to stick to a generic message, correct?

Comment 21

[Maria Angeles Oteo (:oteo)]

Completely correct ;)
A generic message is enough for certification as Beatriz pointed out in comment 11

Comment 22

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Attachment: Github Pull Request

Made tiny changes to Fabien's old patch. It is mainly a rephrasing, so reviewing should be straightforward.

The final phrasing is "FDN is enabled. Make sure the SMS center and the following recipient are in your FDN list: 06xxxxxx"

Comment 23

[Joe Cheng [:jcheng] (please needinfo)]

thanks for the answer maria :) agree

Comment 24

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8401375 [details] [review]
Github Pull Request

LGTM, r+ but please rebase ;)

Comment 25

[Maria Angeles Oteo (:oteo)]

hey Francisco, it seems that Sergi is on PTO until April 30th, and this is a 1.4+ bug and the patch seems to be ready so someone should rebase and finish it... besides it is "late-l10n" :(

Comment 26

[Axel Hecht [:Pike]]

Putting this bug back to triage, as bug 979833. We're way past string freeze.

Comment 27

[Francisco Jordano [:arcturus] [:francisco]]

Taking care of the rebasing and mergin in Sergi's behalf since he is on PTO

Comment 28

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 18124

Carrying over the previous r+ this is just the rebasing branch

Comment 29

[Anthony Ricaud (:rik)]

Please do not merge yet as I've raised a question in bug 979833 comment 12.

Comment 30

[Jason Smith [:jsmith]]

Mainly not blocking because:

1. This breaks string freeze
2. This is a bug that we've already shipped with previously

Comment 31

[Maria Angeles Oteo (:oteo)]

(In reply to Anthony Ricaud (:rik) from comment #29)
> Please do not merge yet as I've raised a question in bug 979833 comment 12.

Question already answered by Carrie (and Omega) in bug 979833 comment 15 and it seems that she's proposing using the same string for Dialer and Messaging

FDN (Fixed Dialing Numbers) is activated and the following number is not in your FDN list:
<phone number>

For messaging we agreed to include too "Make sure the SMSC and all your recipients are in your FDN list", so ni to confirm that you are refering only to the string FDN (Fixed Dialing Numbers) so the final phrasing would be
 "FDN (Fixed Dialing Numbers)is enabled. Make sure the SMS center and the following recipient are in your FDN list: <phone number>

If you could be so kind of clarifying it and provide the total string. Thanks a lot!

Comment 32

[Omega Feng [:Omega] [:馮於懋]]

After discussion with Carrie offline, we decide to use this one:

FDN Active
FDN (Fixed Dialing Numbers) is activated. Make sure the SMS center and the following recipient are in your FDN list:
<phone number>

Comment 33

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8403970 [details] [review]
Pointer to PR 18124

Removing the r+ flag, till new update

Comment 34

[Maria Angeles Oteo (:oteo)]

As Bug 979833 "Inconsistent presentation of message that number is not in FDN list" has just landed in master, requesting 2.0+ to maintain the consistency of the message in both applications dialer and messaging, according to the new string provided by UX team.

Comment 35

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8403970 [details] [review]
Pointer to PR 18124

Just updated the strings according to comment 32, just assigning anyone else but me to take a look to this.

Thanks!

Comment 36

[Julien Wajsberg [:julienw]]

Comment on attachment 8403970 [details] [review]
Pointer to PR 18124

r=me with adding a localization note as a comment

don't hesitate to ask me a review or feedback if you're not sure about something, but otherwise just land after you make this change :)

Comment 37

[Francisco Jordano [:arcturus] [:francisco]]

Good idea, will add the note and merge.

Thanks Julien!

Comment 38

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/arcturus/gaia/commit/48b080705f30ea47d55bc92361ff242054511f21

(Noemi you are on PTO ...)