888912 - [User Story] Entering Numbers into FDN List

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[Wilfred Mathanaraj [:WDM]]

User Story

As a user I want to be able to go to the FDN settings menu and add specific phone numbers/short codes to the FDN list. I want to confirm the entries with PIN2 entry when saving the items and exiting the FDN menu.
As a user I also want to be able to go to the FDN setting menu and add contacts listed in the contacts app to the FDN list - and the FDN settings will display the number of the contact chosen.


Preconditions

* SIM supports FDN
* FDN feature is enabled 
* FDN menu is open

Acceptance Criteria

* ALL entered numbers in the FDN list are displayed in the FDN settings menu
* if a number is changed in contacts app for a contact name and this contact is in the FDN list then the user is informed that this number is part of FDN list.
* any error in setting numbers/contacts in the FDN list should be displayed to user in a clear message

Comment 1

[Gene Lian (I already quit Mozilla)]

The gecko end has already supported FDN as well as the corresponding APIs. Bug 840915 is under way to support the gaia part.

Comment 2

[:gerard-majax]

I'm looking into this. FYI, http://www.etsi.org/deliver/etsi_ts/122100_122199/122101/08.07.00_60/ts_122101v080700p.pdf Annex A.25 (p43).

Comment 3

[Joe Cheng [:jcheng] (please needinfo)]

listed as must have in v1.2 for COMM team. koi+

Comment 4

[Al Tsai [:atsai]]

Comms6, Comms7, Comms8
MozTrap #9026, #9027, #9028, #9035, #9036, #9038, #9039, #9040, #9041

Comment 5

[ayman maat :maat]

Attachment: FFOS_FDN_V1.2_20130807_V2.0.pdf

**RELEASE NOTE**
new wireframes
- none

updated wireframes
- none

deleted wireframes
- none

new flows
- FDN : Turning off FDN
- FDN : Reset PIN2 code
- FDN : Add numbers to FDN List
- FDN : Removing numbers from FDN List
- FDN : Edit numbers from FDN List

updated flows
FDN : Turning on FDN
- annotation to ‘3. Call Settings’ updated

FDN : Reset PIN2 code when PIN2 is blocked
- annotation to ‘3. Call Settings’ updated

deleted flows
- none

Comment 6

[Fabien Cazenave [:kaze]]

Thanks for these wireframes, now working on the implementation.

FTR, editing FDN numbers from the Settings app will probably require a bit of code duplication with the Contacts app.

Comment 7

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Seems it's not moving for a while, may I help on it?

Comment 8

[Fabien Cazenave [:kaze]]

Attachment: link to pull request

https://github.com/mozilla-b2g/gaia/pull/12179

Kudos to Michal for this patch: he did all the work, I only did a bit of refactoring.

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 804297 [details]
link to pull request

Main function works well. r=me with all the comments in github tracked by follow up bugs.

Comment 10

[Michał Budzyński (:michalbe)]

Thanks :kaze & :arthurcc, the fox say 'MERGED' 
https://github.com/michalbe/gaia/commit/ecba11debff049601fa86d76ac003651d7c0018b

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Is the url in comment 10 correct?

Comment 12

[Fabien Cazenave [:kaze]]

Ahem. Merged on master: https://github.com/mozilla-b2g/gaia/commit/beca39db6c9c71e3578d025e1c4c57cde9993900

Just opened these follow-ups: bug 916055, bug 916057, bug 916059, bug 916061.