Closed Bug 976455 Opened 6 years ago Closed 6 years ago

Enabling wifi debug log breaks wifi due to the undefined |p2pManager|

Categories

(Firefox OS Graveyard :: Wifi, defect)

x86_64
Gonk (Firefox OS)
defect
Not set

Tracking

(b2g-v1.4 fixed)

RESOLVED FIXED
1.4 S2 (28feb)
Tracking Status
b2g-v1.4 --- fixed

People

(Reporter: hchang, Assigned: hchang)

References

Details

Attachments

(1 file)

In WifiWorker.js::syncDebug, we should check if p2p supported and p2pManager before calling p2pManager.setDebug(DEBUG).
Attached patch Bug976455.patchSplinter Review
Assignee: nobody → hchang
QA Contact: hchang
Comment on attachment 8381227 [details] [diff] [review]
Bug976455.patch

Review of attachment 8381227 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thank you.
Attachment #8381227 - Flags: review+
Hi henry, can you help to check if we need to nominate this to 1.3 ?
There is no p2p code in 1.3 so 1.3 is safe! Thanks.
Comment on attachment 8381227 [details] [diff] [review]
Bug976455.patch

Review of attachment 8381227 [details] [diff] [review]:
-----------------------------------------------------------------

Solves crashes at b2g startup with wifi debugging enabled here, thank you.
Attachment #8381227 - Flags: feedback+
Blocks: 971637
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6449c32b0ee0
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S2 (28feb)
we need this for Tarako
blocking-b2g: --- → 1.3T+
(In reply to Doug Turner (:dougt) from comment #9)
> we need this for Tarako

Hi Doug,

I've checked branch 1.3T http://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/file/aa0a08ae26cb/dom/wifi
and it seems no need of this patch (as well as bug 976452) Thanks!
According to comment 10, remove 1.3+.
blocking-b2g: 1.3T+ → ---
You need to log in before you can comment on or make changes to this bug.