976455 - Enabling wifi debug log breaks wifi due to the undefined |p2pManager|

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Henry Chang [:hchang]]

In WifiWorker.js::syncDebug, we should check if p2p supported and p2pManager before calling p2pManager.setDebug(DEBUG).

Comment 1

[Henry Chang [:hchang]]

Attachment: Bug976455.patch

Comment 2

[Henry Chang [:hchang]]

https://tbpl.mozilla.org/?tree=Try&rev=92d059c332dd

Comment 3

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 8381227 [details] [diff] [review]
Bug976455.patch

Review of attachment 8381227 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thank you.

Comment 4

[Vincent Chang[:vchang][changyihsin]]

Hi henry, can you help to check if we need to nominate this to 1.3 ?

Comment 5

[Henry Chang [:hchang]]

There is no p2p code in 1.3 so 1.3 is safe! Thanks.

Comment 6

[Douglas Crosher [:dougc]]

Comment on attachment 8381227 [details] [diff] [review]
Bug976455.patch

Review of attachment 8381227 [details] [diff] [review]:
-----------------------------------------------------------------

Solves crashes at b2g startup with wifi debugging enabled here, thank you.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/6449c32b0ee0

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6449c32b0ee0

Comment 9

[Doug Turner (:dougt)]

we need this for Tarako

Comment 10

[Henry Chang [:hchang]]

(In reply to Doug Turner (:dougt) from comment #9)
> we need this for Tarako

Hi Doug,

I've checked branch 1.3T http://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/file/aa0a08ae26cb/dom/wifi
and it seems no need of this patch (as well as bug 976452) Thanks!

Comment 11

[Ken Chang[:kenkai]]

According to comment 10, remove 1.3+.