971637 - [Tarako] Support Geolocation (device has no GPS/A-GPS support)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Al Tsai [:atsai]]

** The case is by the testing on Tarako devices. It might not be able to reproduce on other mobile devices **

Since there's no GPS/A-GPS support, we should remove geolocation checking or related APIs do make sure we won't spend time on waiting for GPS response.

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

triage: 1.3T+ for the release to remove GPS/AGPS

Comment 2

[[:fabrice] Fabrice Desré]

Doug will tell us what to do. Actually, he will do it for us!

Comment 3

[Doug Turner (:dougt)]

Kanru and I discussed tonight.  For the client bits:

1) Modify the location provider interface, and add a method "IsAbleToProvideLocation()" or some nicer name.

2) In the geolocation code, when we create the provider, call "IsAbleToProvideLocation()"
   --  If the response is false, then use the NetworkLocationProvider.js
   --  If the response is true, do what we do now.

3) The implementation of IsAbleToProvideLocation is probably:
    is GonkGPSGeolocationProvider::GetGPSInterface() != nullptr

4) For all B2G builds, we should point the preference geo.wifi.uri at our service.
 
We'll have to make the NetworkLocationProvider.js ship in all builds.  Then, using the magic of XPCOM, we can register a new contract id for this class so that we can always find it.

Comment 4

[Kan-Ru Chen [:kanru] (UTC+9)]

Note that GetGPSInterface() is very slow on some device so you might need to design a async API.

Comment 5

[Doug Turner (:dougt)]

Okay -- ignore comment 3 and 4.


Fabrice said that we can have device specific preferences.  If that is the case, just make the Tarako point at our location service:

https://mozilla-ichnaea.readthedocs.org/en/latest/api/geolocate.html

We should also fix bug 976396.

Comment 6

[[:fabrice] Fabrice Desré]

(In reply to Doug Turner (:dougt) from comment #5)
> Okay -- ignore comment 3 and 4.
> 
> 
> Fabrice said that we can have device specific preferences.  If that is the
> case, just make the Tarako point at our location service:

That was bug 945630

Comment 7

[[:fabrice] Fabrice Desré]

Attachment: fallback-geoloc.patch

Using a pref, that works on my tarako with Mozilla's geo.wifi.uri. Should we change to this one by default too instead of google's ?

Comment 8

[Doug Turner (:dougt)]

Comment on attachment 8381832 [details] [diff] [review]
fallback-geoloc.patch

i'll put up my patch queue soon.  You'll need more than this.

Comment 9

[Doug Turner (:dougt)]

I'm hacking on it here  https://github.com/dougt/gecko-dev/tree/enable_mls_on_b2g

Comment 10

[James Zhang (Spreadtrum)]

Tarako has no GPS hardware, but I think AGPS is depend on network.

Comment 11

[Doug Turner (:dougt)]

All work on this bug is effectively over.  Fabrice will be configuring Tarako to point at our location service provider.

Comment 12

[Joe Cheng [:jcheng] (please needinfo)]

Fabrice, is there a follow up bug for the configuration work? thanks

Comment 13

[[:fabrice] Fabrice Desré]

Yes, bug 978404

Comment 14

[Marvin Khoo [:Marvin_Khoo]]

Hi Fabrice,
could advise if i could get this fix in today build and start verify geolocation related functions / apps?

BR,
Marvin

Comment 15

[[:fabrice] Fabrice Desré]

As soon as bug 978404 is reviewed I'll land the gonk-misc part and partners will take the device part. I let everyone know how to configure builds in bug 977456.

I tested today and it worked fine.

Comment 16

[Marvin Khoo [:Marvin_Khoo]]

got it, thanks Fabrice! :)

Comment 17

[[:fabrice] Fabrice Desré]

We want a different way to set the mls key on 1.5. mwu, dougt and me know what to do.