976452 - Missing implementation of nsIWifi::getWifiScanResults

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Henry Chang [:hchang]]

The implementation of nsIWifi::getWifiScanResults (implemented in WifiWorker.js) was removed but it is actually referenced by other application. We need to add it back

Comment 1

[Henry Chang [:hchang]]

Attachment: Bug976452.patch

Comment 2

[Henry Chang [:hchang]]

https://tbpl.mozilla.org/?tree=Try&rev=7ad8dfe6412b

Comment 3

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 8381219 [details] [diff] [review]
Bug976452.patch

Review of attachment 8381219 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thank you.

Comment 4

[Vincent Chang[:vchang][changyihsin]]

Hi henry, can you help to check if we need to nominate this to 1.3 ?

Comment 5

[Henry Chang [:hchang]]

(In reply to Vincent Chang[:vchang] from comment #4)
> Hi henry, can you help to check if we need to nominate this to 1.3 ?

It's removed after 1.3 branched off the trunk so it's fine for 1.3!

Comment 6

[Doug Turner (:dougt)]

E/GeckoConsole(  179): [JavaScript Error: "p2pManager is undefined" {file: "jar:file:///system/b2g/omni.ja!/components/WifiWorker.js" line: 299}]


Does it need to be wrapped with:
     if (p2pSupported) {}

Comment 7

[Vincent Chang[:vchang][changyihsin]]

(In reply to Doug Turner (:dougt) from comment #6)
> E/GeckoConsole(  179): [JavaScript Error: "p2pManager is undefined" {file:
> "jar:file:///system/b2g/omni.ja!/components/WifiWorker.js" line: 299}]
> 
> 
> Does it need to be wrapped with:
>      if (p2pSupported) {}

We have filed the Bug 976455 to fix that.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/5b0eb7955766

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5b0eb7955766

Comment 10

[Doug Turner (:dougt)]

we need this for Tarako

Comment 11

[Ken Chang[:kenkai]]

According to
https://bugzilla.mozilla.org/show_bug.cgi?id=976455#c10
, remove it from 1.3+.