Closed Bug 976452 Opened 6 years ago Closed 6 years ago

Missing implementation of nsIWifi::getWifiScanResults

Categories

(Firefox OS Graveyard :: Wifi, defect)

x86_64
Gonk (Firefox OS)
defect
Not set

Tracking

(b2g-v1.4 fixed)

RESOLVED FIXED
1.4 S2 (28feb)
Tracking Status
b2g-v1.4 --- fixed

People

(Reporter: hchang, Assigned: hchang)

References

Details

Attachments

(1 file)

The implementation of nsIWifi::getWifiScanResults (implemented in WifiWorker.js) was removed but it is actually referenced by other application. We need to add it back
Attached patch Bug976452.patchSplinter Review
Comment on attachment 8381219 [details] [diff] [review]
Bug976452.patch

Review of attachment 8381219 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thank you.
Attachment #8381219 - Flags: review+
Hi henry, can you help to check if we need to nominate this to 1.3 ?
(In reply to Vincent Chang[:vchang] from comment #4)
> Hi henry, can you help to check if we need to nominate this to 1.3 ?

It's removed after 1.3 branched off the trunk so it's fine for 1.3!
E/GeckoConsole(  179): [JavaScript Error: "p2pManager is undefined" {file: "jar:file:///system/b2g/omni.ja!/components/WifiWorker.js" line: 299}]


Does it need to be wrapped with:
     if (p2pSupported) {}
(In reply to Doug Turner (:dougt) from comment #6)
> E/GeckoConsole(  179): [JavaScript Error: "p2pManager is undefined" {file:
> "jar:file:///system/b2g/omni.ja!/components/WifiWorker.js" line: 299}]
> 
> 
> Does it need to be wrapped with:
>      if (p2pSupported) {}

We have filed the Bug 976455 to fix that.
Blocks: 971637
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5b0eb7955766
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S2 (28feb)
we need this for Tarako
blocking-b2g: --- → 1.3T+
According to
https://bugzilla.mozilla.org/show_bug.cgi?id=976455#c10
, remove it from 1.3+.
blocking-b2g: 1.3T+ → ---
Depends on: 989719
You need to log in before you can comment on or make changes to this bug.