Closed Bug 976839 Opened 6 years ago Closed 6 years ago

GonkPermissionService: Grant AID_RADIO access to android.permission.MODIFY_AUDIO_SETTINGS

Categories

(Firefox OS Graveyard :: Vendcom, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:1.3T+, b2g-v1.3T fixed)

RESOLVED FIXED
1.4 S2 (28feb)
blocking-b2g 1.3T+
Tracking Status
b2g-v1.3T --- fixed

People

(Reporter: m1, Assigned: m1)

References

Details

(Whiteboard: [caf priority: p2][cr 613691])

Attachments

(1 file, 1 obsolete file)

As of kk-gonk some rild implementations require access to android.permission.MODIFY_AUDIO_SETTINGS to setup the voice channel.
Attached patch v1 (obsolete) — Splinter Review
Attachment #8381784 - Flags: review?(mwu)
Whiteboard: [cr 613691]
Comment on attachment 8381784 [details] [diff] [review]
v1

Mind adding a comment for this check? Looks good otherwise.
Attachment #8381784 - Flags: review?(mwu) → review+
comment added, carrying forward r+
Attachment #8381784 - Attachment is obsolete: true
Attachment #8382493 - Flags: review+
Comment on attachment 8382493 [details] [diff] [review]
0001-Bug-976839-Grant-AID_RADIO-access-to-android.permiss.patch

Review of attachment 8382493 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/gonk/GonkPermission.cpp
@@ +40,5 @@
> +
> +  // Some ril implementations need android.permission.MODIFY_AUDIO_SETTINGS
> +  if (uid == AID_RADIO &&
> +      perm8 == "android.permission.MODIFY_AUDIO_SETTINGS")
> +    return true;

nit: add braces
(In reply to Dave Hylands [:dhylands] from comment #4)
> nit: add braces

I'm following the existing style in this file.
Try is green (with a dab of unrelated orange) -- https://tbpl.mozilla.org/?tree=Try&rev=d53874a584d3
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/aef202258c60
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S2 (28feb)
Blocks: 988731
Blocking bug 988731 wich is 1.3T+
blocking-b2g: --- → 1.3T+
Whiteboard: [cr 613691] → [caf priority: p2][cr 613691]
You need to log in before you can comment on or make changes to this bug.