976839 - GonkPermissionService: Grant AID_RADIO access to android.permission.MODIFY_AUDIO_SETTINGS

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Vendcom, defect)

Description

[Michael Vines [:m1] [:evilmachines]]

As of kk-gonk some rild implementations require access to android.permission.MODIFY_AUDIO_SETTINGS to setup the voice channel.

Comment 1

[Michael Vines [:m1] [:evilmachines]]

Attachment: v1

Comment 2

[Michael Wu [:mwu]]

Comment on attachment 8381784 [details] [diff] [review]
v1

Mind adding a comment for this check? Looks good otherwise.

Comment 3

[Michael Vines [:m1] [:evilmachines]]

Attachment: 0001-Bug-976839-Grant-AID_RADIO-access-to-android.permiss.patch

comment added, carrying forward r+

Comment 4

[Dave Hylands [:dhylands]]

Comment on attachment 8382493 [details] [diff] [review]
0001-Bug-976839-Grant-AID_RADIO-access-to-android.permiss.patch

Review of attachment 8382493 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/gonk/GonkPermission.cpp
@@ +40,5 @@
> +
> +  // Some ril implementations need android.permission.MODIFY_AUDIO_SETTINGS
> +  if (uid == AID_RADIO &&
> +      perm8 == "android.permission.MODIFY_AUDIO_SETTINGS")
> +    return true;

nit: add braces

Comment 5

[Michael Vines [:m1] [:evilmachines]]

(In reply to Dave Hylands [:dhylands] from comment #4)
> nit: add braces

I'm following the existing style in this file.

Comment 6

[Michael Vines [:m1] [:evilmachines]]

Try is green (with a dab of unrelated orange) -- https://tbpl.mozilla.org/?tree=Try&rev=d53874a584d3

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/aef202258c60

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/aef202258c60

Comment 9

[[:fabrice] Fabrice Desré]

Blocking bug 988731 wich is 1.3T+

Comment 10

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/709efbc64662