977455 - Switch the Tarako over to use the MLS provider

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Doug Turner (:dougt)]

Attachment: 0003-Switch-geo-wifi-provider-to-MLS.patch

Lets switch over some devices to MLS.

Fabrice, we only want to do this on the Tarako (for now).  Is there a better way?

Comment 1

[[:fabrice] Fabrice Desré]

Comment on attachment 8382750 [details] [diff] [review]
0003-Switch-geo-wifi-provider-to-MLS.patch

Review of attachment 8382750 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/app/b2g.js
@@ +186,4 @@
>  pref("privacy.item.syncAccount", true);
>  
>  // base url for the wifi geolocation network provider
> +pref("geo.provider.use_mls", true);

we'll want that to be false by default, and will just override for devices without gps.

Comment 2

[Doug Turner (:dougt)]

so where will we want to do this override?

Comment 3

[[:fabrice] Fabrice Desré]

(In reply to Doug Turner (:dougt) from comment #2)
> so where will we want to do this override?

We'll configure that at build time: see https://github.com/mozilla-b2g/gonk-misc/pull/149/files

Comment 4

[Doug Turner (:dougt)]

Attachment: bug_977455_enable_mls_b2g

Comment 5

[Doug Turner (:dougt)]

fabrice, this patch just cleans up the main preferences file.  We will still need a gaia change.

Comment 6

[Doug Turner (:dougt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f1c86ed4ccfa


(I am going to file another bug for the gonk change)

Comment 7

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Backed out due to broken Android build:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a761b18588da
https://hg.mozilla.org/integration/mozilla-inbound/rev/01431ff08948
https://hg.mozilla.org/integration/mozilla-inbound/rev/6beb83e91a7d

https://tbpl.mozilla.org/php/getParsedLog.php?id=35459529&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=35460156&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=35460243&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=35459332&tree=Mozilla-Inbound

Comment 8

[Doug Turner (:dougt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fd2a7c560b0c

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/fd2a7c560b0c