978404 - Switch the Tarako over to use the MLS provider

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Doug Turner (:dougt)]

Fabrice, please switch the Tarako specific preference files to point at our location service.  We've agreed on the API key via IRC.

Comment 1

[[:fabrice] Fabrice Desré]

Thinker,

Do you know where we set the device specific prefs for Tarako? I think it makes sense to have them under device/sprd/sp6821a_gonk and use the support from bug 945630.

Comment 2

[Danny Liang [:dliang]]

(In reply to Fabrice Desré [:fabrice] from comment #1)
> Thinker,
> 
> Do you know where we set the device specific prefs for Tarako? I think it
> makes sense to have them under device/sprd/sp6821a_gonk and use the support
> from bug 945630.

We set device specific prefs in device/sprd/sp6821a_gonk/dev-pref.js.

Comment 3

[Joe Cheng [:jcheng] (please needinfo)]

Fabrice, wonder if you can update the status of this bug? thanks

Comment 4

[[:fabrice] Fabrice Desré]

(In reply to Joe Cheng [:jcheng] from comment #3)
> Fabrice, wonder if you can update the status of this bug? thanks

I'll provide a patch soon.

Comment 5

[[:fabrice] Fabrice Desré]

Attachment: geoloc-config.patch

I have another patch for the mozconfig part.

Comment 6

[[:fabrice] Fabrice Desré]

Attachment: mls.patch

mozconfig changes to make it possible to configure an API key for mls.

Comment 7

[[:fabrice] Fabrice Desré]

Attachment: mls.patch

Comment 8

[Doug Turner (:dougt)]

Comment on attachment 8392548 [details] [diff] [review]
geoloc-config.patch

Review of attachment 8392548 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 9

[[:fabrice] Fabrice Desré]

James, can you land attachment 8392548 [details] [diff] [review] on your device branch? thanks!

Comment 10

[James Zhang (Spreadtrum)]

commit 8a88ca86ee9ddb202375b824267b8f820ba708cd
Author: james.zhang <[e-mail]>
Date:   Wed Mar 19 11:20:08 2014 +0800

    Bug#269156 merge patch from mozilla, Bug 978404 - Switch the Tarako over to use the MLS provider
    
    Change-Id: If1f61ae5eaa042e960bc0e2c7f00274fbf5cfd60

Comment 11

[Michael Wu [:mwu]]

Comment on attachment 8392676 [details] [diff] [review]
mls.patch

r=me for v1.3t *only*

Comment 12

[[:fabrice] Fabrice Desré]

landed as cd4b17765cc6caa1ffebc30a43eaee7cf4879ab1 in gonk-misc v1.3t

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to revert this in https://github.com/mozilla-b2g/gonk-misc/commit/adfafeca79b9f32a05588bcd7d720a528cd91064 for breaking the 1.3t build on TBPL: 
https://tbpl.mozilla.org/php/getParsedLog.php?id=36406563&tree=Mozilla-B2g28-v1.3t


It's a bunch of different failures due to:
mv: cannot stat `build_stage/application.zip': No such file or directory

Comment 14

[[:fabrice] Fabrice Desré]

Hm, what really break us is not the zip errors but:
12:07:32    ERROR -  make[3]: *** [scripts/basic/fixdep] Error 2
12:07:32    ERROR -  make[2]: *** [scripts_basic] Error 2
12:07:32    ERROR -  make[1]: *** [sub-make] Error 2
12:07:32     INFO -  make[1]: Leaving directory `/builds/slave/b2g_m-b28_v1_3t_tko_eng_dep-00/build/kernel'
12:07:32     INFO -  make: *** [kernelheader] Error 2
12:07:32     INFO -  make: *** Waiting for unfinished jobs....
12:07:32     INFO -  Done

Not sure what's happening, I'll take a look tomorrow.

Comment 15

[[:fabrice] Fabrice Desré]

And of course I can't reproduce on a fresh local build...

Comment 16

[[:fabrice] Fabrice Desré]

And the error from comment 14 is still happening intermittently. Wes, do you mind relanding?

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Unreverted in https://github.com/mozilla-b2g/gonk-misc/commit/56bd55e0514a4daa61b036d223edb36e5ae9b1ec

We'll see how it goes.

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

And re-reverted in https://github.com/mozilla-b2g/gonk-misc/commit/bb230eece04e709679ea9bb329d8a32d0f4fce95 because it failed again in the exact same way: https://tbpl.mozilla.org/php/getParsedLog.php?id=36483320&tree=Mozilla-B2g28-v1.3t

Comment 19

[[:fabrice] Fabrice Desré]

How do you explain all the others exact same failures without this change? See a86cf28cc78a that was red on first build and green when restarted.

Comment 20

[[:fabrice] Fabrice Desré]

So, 2 greens and 2 reds on the push you reverted, and the backout is red. Clearly this patch is not the cause of the intermittent failure.

Comment 21

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Re-relanded in https://github.com/mozilla-b2g/gonk-misc/commit/575204d5d39f8b9329fb47a80db616c2362bf488

Comment 22

[[:fabrice] Fabrice Desré]

We want a different way to set the mls key on 1.5. mwu, dougt and me know what to do.

Comment 23

[bhavana bajaj [:bajaj]]

(In reply to Fabrice Desré [:fabrice] from comment #22)
> We want a different way to set the mls key on 1.5. mwu, dougt and me know
> what to do.

:fabrice/:dougt, do we have a filed bug you can point me to for tracking purposes? Thanks !

Comment 24

[Ivan Tsay (:ITsay)]

Traige: Already have another bug 1009761 for partner to import the key. No need for v1.4