Closed
Bug 977456
Opened 10 years ago
Closed 10 years ago
Provide a mozilla api key for Tarako MLS support
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(blocking-b2g:1.3T+, b2g-v1.3T fixed)
People
(Reporter: dougt, Assigned: fabrice)
References
Details
(Whiteboard: [POVB])
Similar to what we do on desktop, we need the OEM to configure their build to specify a mozilla API key. This will be done via a build configure option.
Reporter | ||
Comment 1•10 years ago
|
||
chris, can you put me in touch with whomever will do the builds for the tarako so that I can provide them with a key.
Flags: needinfo?(clee)
Reporter | ||
Updated•10 years ago
|
Assignee: dougt → fabrice
Updated•10 years ago
|
Flags: needinfo?(dliang)
Comment 3•10 years ago
|
||
What does MLS mean?
Assignee | ||
Comment 4•10 years ago
|
||
MLS is Mozilla Location Service: https://location.services.mozilla.com/
Comment 5•10 years ago
|
||
looks like we need our partner to take this in their final build [POVB] Steven, can you connect Doug to partner? thanks
Flags: needinfo?(styang)
Whiteboard: [POVB]
You can ni james.zhang@spreadtrum.com or me.
Comment 7•10 years ago
|
||
hi Doug, do we need to provide the keys privately? or publicly is fine? thanks
Flags: needinfo?(dougt)
Assignee | ||
Comment 8•10 years ago
|
||
We'd rather not check in the keys. I'll let people know how to set this up once the situation in bug 978404 is sorted out.
Assignee | ||
Comment 9•10 years ago
|
||
I sent the informations by email. Let's close this bug once we can verify that builds are set up and work properly.
Comment 10•10 years ago
|
||
bug978404 was landed by sprd. How to verify MLS?
Assignee | ||
Comment 11•10 years ago
|
||
(In reply to thomas tsai from comment #10) > bug978404 was landed by sprd. How to verify MLS? I sent the instructions to set up the build properly to sprd. Once they are ready we should just verify eg. with a page like http://html5demos.com/geo
Comment 12•10 years ago
|
||
1 diff --git a/configure.in b/configure.in 2 index f15a801..780d682 100644 3 --- a/configure.in 4 +++ b/configure.in 5 @@ -4113,7 +4113,7 @@ MOZ_ARG_WITH_STRING(mozilla-api-keyfile, 6 [ --with-mozilla-api-keyfile=file Use the secret key contained in the given keyfile for Mozilla API requests], 7 MOZ_MOZILLA_API_KEY=`cat $withval`) 8 if test -z "$MOZ_MOZILLA_API_KEY"; then 9 - MOZ_MOZILLA_API_KEY=no-mozilla-api-key 10 + MOZ_MOZILLA_API_KEY=xxxxxxxxxxxxxxxxxx 11 fi 12 AC_SUBST(MOZ_MOZILLA_API_KEY) 13 I think we must move this gecko configure.in patch to device/sprd/dev_pref.js. We can't fix it by WIP patch because mozilla build exclude patch.
Flags: needinfo?(ttsai)
Flags: needinfo?(fabrice)
Comment 13•10 years ago
|
||
(In reply to thomas tsai from comment #10) > bug978404 was landed by sprd. How to verify MLS? Fabrice give us the key, but we also don't know how to verify. And I think we should add it on my device/sprd git repo, not gecko git repo.
Assignee | ||
Comment 14•10 years ago
|
||
You must not change gecko's configure.in at all. The only thing that needs to be done is to set the MOZILLA_MLS_KEY_FILE environment variable to locate a file that holds the mls key I sent you.
Flags: needinfo?(fabrice)
Comment 15•10 years ago
|
||
(In reply to Fabrice Desré [:fabrice] from comment #14) > You must not change gecko's configure.in at all. The only thing that needs > to be done is to set the MOZILLA_MLS_KEY_FILE environment variable to locate > a file that holds the mls key I sent you. We dont have places to put .userconfig and MOZILLA_MLS_KEY_FILE file. B2G/gecko/gaia are all mozilla code repositories.
Assignee | ||
Comment 16•10 years ago
|
||
That should be part of your build setup, out of tree. I don't know what to tell you. cc-ing catlee that may shed some light on how we do this kind of things at mozilla.
Flags: needinfo?(catlee)
Comment 17•10 years ago
|
||
Danny can also work with sprd to solve it with the provided key.
Flags: needinfo?(ttsai) → needinfo?(dliang)
Reporter | ||
Comment 18•10 years ago
|
||
keys have been given to fabrice for sprd. note that these are per device type keys. that is, only tarako should use this key. if sprd is using another device type, we will issue a different key.
Flags: needinfo?(dougt)
Comment 20•10 years ago
|
||
fixed on my side commit bbbe4348b69d404da1e4556e79f6cbd987f95f31 Author: james.zhang <james.zhang@spreadtrum.com> Date: Tue Mar 25 17:35:03 2014 +0800 Bug#269156 merge patch from mozilla, Bug 978404 - Switch the Tarako over to use the MLS provider [bug number ] [root cause ] [changes ] [side effects] [self test ] self test [reviewers ] Change-Id: I5d14bee5def9a3fa52a67646ea73c159e90ba598
Comment 21•10 years ago
|
||
(In reply to Fabrice Desré [:fabrice] from comment #16) > That should be part of your build setup, out of tree. I don't know what to > tell you. cc-ing catlee that may shed some light on how we do this kind of > things at mozilla. What we've typically done is have the mozconfig refer to the API key on disk, and use configuration management tools to ensure the API key is deployed to all the machines. e.g. http://hg.mozilla.org/releases/mozilla-release/file/20f4d6fe9591/browser/config/mozconfigs/linux64/common-opt#l5 we manage all our build machines with puppet, so we can make sure they all have the proper API key.
Flags: needinfo?(catlee)
Updated•10 years ago
|
Flags: needinfo?(styang)
Comment 22•10 years ago
|
||
(In reply to Chris AtLee [:catlee] from comment #21) > (In reply to Fabrice Desré [:fabrice] from comment #16) > > That should be part of your build setup, out of tree. I don't know what to > > tell you. cc-ing catlee that may shed some light on how we do this kind of > > things at mozilla. > > What we've typically done is have the mozconfig refer to the API key on > disk, and use configuration management tools to ensure the API key is > deployed to all the machines. e.g. > > http://hg.mozilla.org/releases/mozilla-release/file/20f4d6fe9591/browser/ > config/mozconfigs/linux64/common-opt#l5 > > we manage all our build machines with puppet, so we can make sure they all > have the proper API key. Hi Chris, as I know, this configured file was located in gecko, should we modify this file for project specific setting or configuration? I think to proper location to save MLS key and environment variable is under device/sprd. Please advise me if any misunderstanding.
Flags: needinfo?(catlee)
Comment 23•10 years ago
|
||
commit bbbe4348b69d404da1e4556e79f6cbd987f95f31 Author: james.zhang <james.zhang@spreadtrum.com> Date: Tue Mar 25 17:35:03 2014 +0800 Bug#269156 merge patch from mozilla, Bug 978404 - Switch the Tarako over to use the MLS provider
Comment 24•10 years ago
|
||
(In reply to Danny Liang [:dliang] from comment #22) > (In reply to Chris AtLee [:catlee] from comment #21) > > (In reply to Fabrice Desré [:fabrice] from comment #16) > > > That should be part of your build setup, out of tree. I don't know what to > > > tell you. cc-ing catlee that may shed some light on how we do this kind of > > > things at mozilla. > > > > What we've typically done is have the mozconfig refer to the API key on > > disk, and use configuration management tools to ensure the API key is > > deployed to all the machines. e.g. > > > > http://hg.mozilla.org/releases/mozilla-release/file/20f4d6fe9591/browser/ > > config/mozconfigs/linux64/common-opt#l5 > > > > we manage all our build machines with puppet, so we can make sure they all > > have the proper API key. > > Hi Chris, as I know, this configured file was located in gecko, should we > modify this file for project specific setting or configuration? I think to > proper location to save MLS key and environment variable is under > device/sprd. Please advise me if any misunderstanding. Indeed, it looks like device/sprd/sp6821a_gonk/prod_sp6821a.mk requires the file to be present at $(ANDROID_BUILD_TOP)/$(BOARDDIR)/mls.key
Flags: needinfo?(catlee)
Assignee | ||
Comment 26•10 years ago
|
||
Yes, let's close that one.
Status: NEW → RESOLVED
Closed: 10 years ago
status-b2g-v1.3:
--- → fixed
Flags: needinfo?(fabrice)
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
status-b2g-v1.3:
fixed → ---
status-b2g-v1.3T:
--- → fixed
Reporter | ||
Updated•10 years ago
|
Flags: needinfo?(clee)
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•