Closed
Bug 977627
Opened 11 years ago
Closed 11 years ago
[Download Manager] Files delete notification lacks plural support
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(blocking-b2g:1.4+, b2g-v1.4 fixed)
Tracking | Status | |
---|---|---|
b2g-v1.4 | --- | fixed |
People
(Reporter: Pike, Assigned: kaze)
References
Details
(Keywords: l12y, Whiteboard: [systemsfe])
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #970225 +++
+delete_all_download_message = Delete {{number}} files?
needs to be hooked up the plurals logic, as languages like Polish and Russian have different translations for 2 and 4 files.
Plural isn't just 1 or more across languages.
Reporter | ||
Comment 1•11 years ago
|
||
Requesting 1.4, this prevents this UI from being properly localized.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → kaze
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #8383080 -
Flags: review?(l10n)
Reporter | ||
Comment 3•11 years ago
|
||
Comment on attachment 8383080 [details] [review]
link to pull request
r=me. The zero case made me smile, but I guess that's the right string for completeness.
no key change in the code is OK in this case, in case folks observe this landing, for two reasons: The keys change in the localization files, plus, I didn't actually push the changesets out to localizers to avoid wasting their time.
Attachment #8383080 -
Flags: review?(l10n) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Merged on master: https://github.com/mozilla-b2g/gaia/commit/f1efd57fed3679601fd22ba1d32bf77e6f829802
(In reply to Axel Hecht [:Pike] from comment #3)
> r=me. The zero case made me smile, but I guess that's the right string for
> completeness.
Yes, it’s completely artificial. :-D
I hope the localization note makes it clear.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
blocking-b2g: 1.4? → 1.4+
Comment 5•11 years ago
|
||
I think it's better than the person who opened the bug put it as verified.
Axel Hecht can check the bug and put it as verified->fixed?
Reporter | ||
Comment 6•11 years ago
|
||
i generally disagree, and in this case, I don't speak affected language, so I can't verify
Updated•11 years ago
|
status-b2g-v1.4:
--- → fixed
Target Milestone: --- → 1.4 S2 (28feb)
You need to log in
before you can comment on or make changes to this bug.
Description
•