978549 - backport bug 916633 to bmo (join_activity_entries doesn't reconstitute text with commas correctly)

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Kyle Lahnakoski [:ekyle]]

Looking at the last change in the user story on https://bugzilla.mozilla.org/show_activity.cgi?id=937428

> @@ -1 +1 @@
> -before china goes live (end January developer release, June general audience release), the content team will have to manually update the settings for the china-ready apps currently in marketplace.
> +before china goes live , the content team will have to manually update the settings for the china-ready apps currently in marketplace.

There is a space between "live" and the comma.  This space is missing from the current user story:

> before china goes live, the content team will have to manually update the settings for the china-ready apps currently in marketplace. 
> 
> kward has the details.
> ...

Can I assume whitespace changes are not recorded?  What of the whitespace that separates words?  "user story" and "userstory" are different when it comes to text search.

Comment 1

[:glob ✱]

that's an artefact of how rows in the bugs_activity table are split and re-joined to work around the 255 byte limit.  spaces are inserted under certain circumstances when a row is joined, resulting in what appears to be an errant space being ignored.

the actual values in the database are:

@@ -1 +1 @@ -before china goes live (end January developer release, June general audience release), the content team will have to manually update the settings for the china-ready apps currently in marketplace. +before china goes live

, the content team will have to manually update the settings for the china-ready apps currently in marketplace. @@ -3 +3

,6 @@ -kward has the details.+kward has the details. + +Target Release Dates : +https://mana.mozilla.org/wiki/display/PM/Firefox+OS+Wave+Launch+Cross+Functional+View + +Content Team Engagement & Tasks : https://appreview.etherpad.mozilla.org/40


it looks like the patch on bug 916633 fixes this issue:

Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified Bugzilla/Bug.pm
Committed revision 9261.