978809 - [Bluetooth] Send ToggleBtAck at end of BT setup

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

We need to send ToggleBtAck after BT connections have been fully set up.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 978809: Remove sToggleBtMonitor from Bluedroid backend

The Bluedroid library does all its multi-threading internally and the use of sToggleBtMonitor was the only reason why Bluedroid used the BT thread AFAICS. After some more cleanups, we can push the BT thread completely into the BlueZ backend.

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [02] Bug 978809: Send ToggleBtAck after finishing BlueZ connection setup

Moving ToggleBtAck to the end of the BlueZ setup is really only the first step. We should also refactor StopInternal such that it doesn't touch sDBusConnection on the BT thread.

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

I tested both patches on the Nexus 4 and the Unagi.

Comment 4

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 8384660 [details] [diff] [review]
[01] Bug 978809: Remove sToggleBtMonitor from Bluedroid backend

Review of attachment 8384660 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good :)

Comment 5

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 8384663 [details] [diff] [review]
[02] Bug 978809: Send ToggleBtAck after finishing BlueZ connection setup

Review of attachment 8384663 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nit addressed. Waiting for the next patch. :)

::: dom/bluetooth/bluez/BluetoothDBusService.cpp
@@ +1854,5 @@
>  
>    void Run()
>    {
> +    MOZ_ASSERT(!sDBusConnection);
> +  

nit: whitespaces

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [02] Bug 978809: Send ToggleBtAck after finishing BlueZ connection setup (v2)

Changes to v1:

  - cleaned up whitespace error

Comment 7

[Thomas Zimmermann [:tzimmermann] [:tdz]]

https://hg.mozilla.org/integration/b2g-inbound/rev/8eb485a8503e
https://hg.mozilla.org/integration/b2g-inbound/rev/f7444f0ee3b9

https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=f7444f0ee3b9

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8eb485a8503e
https://hg.mozilla.org/mozilla-central/rev/f7444f0ee3b9