979530 - [B2G][Clock] The text alarm in the notification banner is cutoff

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[KTucker [:KTucker][Inactive 3/4/2016]]

Attachment: 2014-03-04-11-54-18.png

Description:
The text "Alarm" appears cutoff in the gray notification banner when an alarm is going off. 

Repro Steps:
1)  Updated Buri to Build ID: 20140304040200
2)  Set an alarm to go off 1 minute from now.
3)  When the alarm goes off, press the "Home" button on the phone and observe the alarm notification banner at the top of the screen. 

Actual:
The text "Alarm" appears cutoff on the notification banner.

Expected:
The text "Alarm" is not cutoff and appears correctly on the notification banner.

Environmental Variables
Device: Buri v 1.4.0 Mozilla RIl
Build ID: 20140304040200
Gecko: https://hg.mozilla.org/mozilla-central/rev/529b86b92b1d
Gaia: 6df4533f14ec2645bb13d8a803a5151583ca13a8
Platform Version: 30.0a1
Firmware Version: v1.2-device.cfg

Notes:
Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/8509/
See attached: screenshot

Comment 1

[KTucker [:KTucker][Inactive 3/4/2016]]

This issue does not occur on the Buri v 1.3.0 Mozilla RIL

Environmental Variables
Device: Buri v 1.3.0 Mozilla RIL
Build ID: 20140303004002
Gecko: https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/e5e02efda8ad
Gaia: d51d2e0963d9b761d5ea96243dfb13d9a220d521
Platform Version: 28.0
RIL Version: 01.02.00.019.102 
Firmware Version: v1.2-device.cfg

The text "Alarm" appears correctly in the notification banner.

Comment 2

[Brogan Zumwalt [Inactive]]

Regression Window:

Unable to provide deeper information from tinderbox or inbound builds as these are not available for given dates. Issue has same regression window as bug 978683.

Issue appears to be Gaia related.

Last Working Build:
Device: Buri v1.4 Master Mozilla RIL
BuildID: 20140116040206
Gaia: 82878ba16172213cd00ba3e8b377564b290e59c1
Gecko: 324e2cba1029
Version: 29.0a1
Firmware Version: v1.2-device.cfg


First Broken Build:
Device: Buri v1.4 Master Mozilla RIL
BuildID: 20140117041037
Gaia: ef8bb31b462f364b57432a0724c78034d3f4f303
Gecko: b53589696cf8
Version: 29.0a1
Firmware Version: v1.2-device.cfg


Last Working Gaia/First Broken Gecko: Issue does NOT reproduce
Gaia: 82878ba16172213cd00ba3e8b377564b290e59c1
Gecko: b53589696cf8

First Broken Gaia/Last Working Gecko: Issue DOES reproduce
Gaia: ef8bb31b462f364b57432a0724c78034d3f4f303
Gecko: 324e2cba1029

https://github.com/mozilla-b2g/gaia/compare/82878ba16172213cd00ba3e8b377564b290e59c1...ef8bb31b462f364b57432a0724c78034d3f4f303

Comment 3

[Jason Smith [:jsmith]]

Marcus - Looks like we got another regression from bug 898354. Can you look into this?

Comment 4

[Marcus Cavanaugh [:mcav]]

Attachment: Fixed Screenshot

Comment 5

[Marcus Cavanaugh [:mcav]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16909

The second attachment shows a screenshot of the corrected status bar. Someone forgot to update a CSS class name; additionally, the icon was lacking padding so I bumped the other numbers slightly.

Comment 6

[Marcus Cavanaugh [:mcav]]

Thanks, James. Landed:

https://github.com/mozilla-b2g/gaia/commit/44817329094db82071ba537531323f2df5b76e51

Comment 7

[Edward Chen[:edchen]]

[Environment]
Gaia      6c109df47006b08c082761c0ddd6ba53a864983a
Gecko     https://hg.mozilla.org/mozilla-central/rev/21f293fc8d34
BuildID   20140309160201
Version   30.0a1
ro.build.version.incremental=eng.archermind.20131114.105818
ro.build.date=Thu Nov 14 10:58:33 CST 2013


[Result]
PASS

The bug fixed, I marked it to "Verified".