980398 - Remove navigator.mozMobileConnection uses from the cost control app

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Gabriele Svelto [:gsvelto]]

The cost control app still uses navigator.mozMobileConnection in one place and in some unit-tests; this should be removed and the relevant code must be made to rely only on navigator.mozMobileConnections (and its mock for the tests).

Comment 1

[Marina Rodríguez [:mai]]

Attachment: patch v1.0

Could you review the patch?
Regards

Comment 2

[Salvador de la Puente González [:salva]]

Comment on attachment 8388410 [details] [review]
patch v1.0

Despite I totally agree with this change. Let's land the manager with its tests first and then, in a follow up, we land the adaptation of the current CC. Remove the adaptation part and ask for my review again.

Thank you.

Comment 3

[Salvador de la Puente González [:salva]]

Ups, this comment is for bug 977077

Comment 4

[Gabriele Svelto [:gsvelto]]

While looking around I've noticed that this variable is not used anymore and the check it does is always true, it would be good if you could remove it as part of this bug:

https://github.com/mozilla-b2g/gaia/blob/c3c12544f7acbf0e66d7d481c0718634e068d3ce/apps/costcontrol/js/widget.js#L22

Comment 5

[Marina Rodríguez [:mai]]

Hi Gabriele,

this is not completely true, on b2g-desktop mobileConnections is undefined as you can see on the Bug 986833 -The cost control app doesn't work on b2g-desktop. I have to put this check on the startup of my application.

Regards

Comment 6

[Gabriele Svelto [:gsvelto]]

> this is not completely true, on b2g-desktop mobileConnections is undefined
> as you can see on the Bug 986833 -The cost control app doesn't work on
> b2g-desktop. I have to put this check on the startup of my application.

I see, makes sense.

Comment 7

[Marina Rodríguez [:mai]]

Comment on attachment 8388410 [details] [review]
patch v1.0

Updated the PR, Salva, could you review the patch?
Regards

Comment 8

[Salvador de la Puente González [:salva]]

Comment on attachment 8388410 [details] [review]
patch v1.0

Please address the problems on GitHub and ask for my review again.
Thank you!

Comment 9

[Marina Rodríguez [:mai]]

Comment on attachment 8388410 [details] [review]
patch v1.0

>https://github.com/mozilla-b2g/gaia/pull/17017

Comment 10

[Marina Rodríguez [:mai]]

Resolved by bug 977077