981420 - When navigating to an "about:" URL from a page with an external app icon, the icon remains in URL bar

Status: RESOLVED DUPLICATE of bug 981483

(Firefox for Android Graveyard :: General, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Visit http://techslides.com/demos/sample-videos/small.mp4 in Firefox Nightly for Android. (or any mp4 file). Note the little android icon in the URL bar.
 2. Tap the URL bar, and type in an "about:" URL. (e.g. "about:" or "about:home"
 3. Examine the URL bar, after the about page has loaded.

ACTUAL RESULTS: external app android icon remains.

EXPECTED RESULTS: external app icon should be gone.

Looks like this is a regression w.r.t. most recent release, at least:
Firefox Nightly gives the broken ACTUAL RESULTS. Version 30.0a1 2014-03-08
Firefox release gives EXPECTED RESULTS. Versions 27.0, 28.0

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot

Here's a screenshot showing the icon sticking around on about: .

(FWIW: When I tap the icon, it prompts me to open the video player, which then says "Can't play this video". I can't be sure whether it's trying & failing to play some bogus "about:" video, or whether it's actually trying to play the mp4 file from my history and just failing due to bug 981345.)

Comment 2

[Aaron Train [:aaronmt]]

This is bug 969835 which is fixed on trunk (30).

Comment 3

[Daniel Holbert [:dholbert]]

I don't think so... That bug's patch landed a month ago, whereas I'm seeing this bug in current Fennec nightly.

Seems possible that this might've been *caused* by bug 969835's patch, though. (i.e. if we're bailing out early from looking for helper apps, maybe we bail out before we clear the left-over-from-previous-page helper-app button?)

Comment 4

[Eugen Sawin [:esawin]]

Bug 981483 shows a more general problem with the clearing and updating of page actions.

Comment 5

[Daniel Holbert [:dholbert]]

Yup, I think they're effectively duplicates of each other.

I'll dupe this to the other bug, since the other bug has a patch & more information.