Closed
Bug 982830
Opened 12 years ago
Closed 12 years ago
[marionette-helper] add closest method
Categories
(Testing Graveyard :: JSMarionette, defect)
Testing Graveyard
JSMarionette
Tracking
(Not tracked)
RESOLVED
FIXED
1.4 S3 (14mar)
People
(Reporter: mmedeiros, Assigned: mmedeiros)
Details
(Whiteboard: [p=2])
Attachments
(1 file)
In some tests it would be useful to have a method similar to [jQuery.fn.closest](http://api.jquery.com/closest/) to quickly return an element that is on a "parent" node in the DOM tree. It can simplify the test process a lot.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → mmedeiros
Whiteboard: [p=2]
Target Milestone: --- → 1.4 S3 (14mar)
|
|
Assignee | |
Comment 1•12 years ago
|
||
as discussed on IRC, I added a `closest` method to help testing some parts of the calendar app (specially Bug 982240)
Attachment #8390044 -
Flags: review?(gaye)
|
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8390044 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/marionette-helper/pull/23
I had a couple nits on GH, but in general this looks good. Thanks miller!
Attachment #8390044 -
Flags: review?(gaye) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
fixed nits and landed: https://github.com/mozilla-b2g/marionette-helper/commit/986358d6ca01013c9245626a27c218827ef41b05
also created a Bug 983795 (Element#scriptWith) to simplify this kind of task in the future.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•