Closed Bug 983749 Opened 8 years ago Closed 7 years ago

Locale priorization for translations

Categories

(addons.mozilla.org Graveyard :: Code Quality, defect, P2)

x86_64
Linux
defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: magopian, Assigned: magopian)

References

Details

(Whiteboard: [repoman])

Following discussions with @mat on https://bugzilla.mozilla.org/show_bug.cgi?id=902435#c3, we came to the conclusion that we need some kind of "locale priorization" when selecting a translation for a translated field.

Here's the desired behavior:
1/ select the translation for the current language, if it exists
2/ otherwise fallback to the model's fallback language (if it has a "get_fallback()" method), if it exists
3/ otherwise fallback to the "en-US" (settings's default), if it exists
4/ otherwise return just any translation found (this is what is already done for translated fields with the "require_locale" set to False)

With this, we can safely remove a locale, as long as it's not the last available one.
Blocks: 902435
Component: Localization → Code Quality
Priority: -- → P2
Blocks: 984866
Is this bug a Marketplace or AMO bug?  (noting the depends on 902435).  Giving the upcoming split it would probably make sense to clone them if it really does affect both code bases.
It's both. See also bug 984866 (which also belongs to both Marketplace and AMO) about the future for that part of the code.
Assignee: nobody → mathieu
Depends on: 988376
Whiteboard: [repoman]
Closing this as wontfix, see the comments in the PR
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.