984503 - Add "Remove Firefox Account" option to FxAccount status activity

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Nick Alexander :nalexander [he/him]]

This is already possible from Android Settings > Accounts, but it's not very intuitive.  We might want to make this a menu, so it's not really visible; but it's available for SUMO, etc.

Comment 1

[Nick Alexander :nalexander [he/him]]

ibarlow: do you have strong thoughts about this?

Comment 2

[Ian Barlow (:ibarlow)]

(In reply to Nick Alexander :nalexander from comment #1)
> ibarlow: do you have strong thoughts about this?

To be honest I don't... I can see the argument for wanting to make it easier for users to access, but I also wonder how much people are looking for it and how much we actually want to expose it? 

It might be the kind of thing we would want to provide easier access if we reach a point where users can add more than one Firefox Account to Fennec, which *might* lead to users adding the wrong account to a profile or something. I can't really see value in prioritizing this work before then, though.

Comment 3

[Aaron Train [:aaronmt]]

Yes, been looking for a way to do this but missed this bug. I like Chrome's bottom row 'disconnect Google Account' and warning dialog ("If you stop syncing, the data stored on this device as well as the data stored in your Google Account will remain in both placed. However, new data or changes you make to your data will not be synchronized between them")

Comment 4

[Nick Alexander :nalexander [he/him]]

This is a good nth bug.  vivek, are you interested?

The code changes will be in https://github.com/mozilla-services/android-sync.

0. Add appropriate strings for button label and warning messages.

1. Add button to FxA preferences screen, or add menu to the status activity.

2. Connect button to "delete account alert dialog" in FxAccountStatusFragment.

3. Implement deleting the account entirely (using the AccountManager).

Comment 5

[Vivek Balakrishnan[:vivek]]

Yes, I'm interested in working on this bug.

Comment 7

[Vivek Balakrishnan[:vivek]]

Attachment: link to github patch

Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/477

Comment 8

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8476256 [details] [review]
link to github patch

Sorry I took so long to get to this.  This is awesome, great patch!  My only concern is showing the menu on phones that don't have a hardware menu button.  We show the three dots menu by hand in various parts of Fennec: see around http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/toolbar/BrowserToolbar.java#1469

One way we might do this is to optionally add an extra "status option" that says, for example, "More..." and pops up the menu.  We'll need to think about this and solicit feedback from a UX person.  You can see where we do something like this at http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/toolbar/BrowserToolbar.java#491.

Can you see what optionally adding that menu looks like (as a second commit, on top of what you've done)?

Once again, sorry for the slow feedback loop.  This is basically ready to land!

Comment 9

[Nick Alexander :nalexander [he/him]]

I forgot to mention: review comments on the github pull request.

Comment 10

[Nick Alexander :nalexander [he/him]]

Attachment: Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/480

Take a quick look at the final 3 commits, rnewman.  (And vivek!)

Comment 11

[Richard Newman [:rnewman]]

Comment on attachment 8480886 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/480

LGTM. Questions in the pull req.

Comment 12

[Nick Alexander :nalexander [he/him]]

Pushed with some additional commits.  Thanks for making this happen, vivek!

https://hg.mozilla.org/integration/fx-team/rev/56c4334e838f
https://hg.mozilla.org/integration/fx-team/rev/579667582c6a

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back these out for android build bustage: https://hg.mozilla.org/integration/fx-team/rev/8e8408501fd1



https://tbpl.mozilla.org/php/getParsedLog.php?id=47045469&tree=Fx-Team

Comment 14

[Nick Alexander :nalexander [he/him]]

This was a legitimate issue caused by a problem in the android-sync repository.  Relanding with the fix:

https://hg.mozilla.org/integration/fx-team/rev/ac1087bb734e
https://hg.mozilla.org/integration/fx-team/rev/a0e6a11d7b8b
https://hg.mozilla.org/integration/fx-team/rev/924887478138

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ac1087bb734e
https://hg.mozilla.org/mozilla-central/rev/a0e6a11d7b8b
https://hg.mozilla.org/mozilla-central/rev/924887478138