984764 - [camera] Beep Sounds When self-timer reaches 3~1

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[singhashish1887]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140317030202

Steps to reproduce:

1. Goto Camera App
2. Set self timmer to 3/5/10 seconds in Settings
3. Take a picture and video



Actual results:

Beep sound is not played in 1~3 seconds


Expected results:

Beep sound should play in 1~3 seconds

Comment 1

[singhashish1887]

Attachment: Pull Request(Camera-new-feature)

Comment 2

[Wilson Page [:wilsonpage]]

Comment on attachment 8392736 [details] [review]
Pull Request(Camera-new-feature)

Landed on camera-new-features

Comment 3

[Diego Marcos [:dmarcos]]

Landed on camera-new-features:

https://github.com/mozilla-b2g/gaia/commit/1dad30933834baabf396f2f8c46ed89001313fdb

Comment 4

[Wilson Page [:wilsonpage]]

Reopening this to track the self timer sound being decoupled from the recording start/stop sound that is tied into Gaia Settings.

We want the self-timer sound to be tied to main device volume level as discussed in bug 985578.

Comment 5

[Tiffanie Shakespeare [:tif]]

Comment on attachment 8392736 [details] [review]
Pull Request(Camera-new-feature)

As Wilson states, in comment 4, the self-timer countdown should not be tied to the video recording setting toggle in Settings->Sounds. 

Flagging Dominic to comment on how to tie self-timer countdown to notification sounds and adding Omega to thread as discussion was occurring in Bug 985578.

Comment 6

[Dominic Kuo [:dkuo]]

(In reply to Wilson Page [:wilsonpage] from bug 985578 comment #24)
> Omega: So can you instruct on how I would ensure this particular sound is in
> the #2 category?

Hey Wilson, here is the wiki page of the audio channels, and you can find how to set a proper channel type to the beep sounds: https://wiki.mozilla.org/WebAPI/AudioChannels

And according the wiki, I think the beep sound should belongs to "public notification" since it's camera sounds, and you can write the code like:

1. Add the audio channel permission to the manifest.webapp:
...
"audio-channel-publicnotification":{}
...
(You can add more than one channels if you have different channels in camera app)

2. Set the channel type to the target audio element(or web audio context):
...
audio.mozAudioChannelType = 'publicnotification';
...

With these code I think the beep sounds should follow the rules of audio channels, though there are some known issues we couldn't address before 1.5. And if you have time, please take a look on bug 958470, which I recently landed for the ringtones app to fix the related issue, the two patches are good examples to demonstrate who to set proper channel on both audio element or web audio context, let me know if you have problems on it, thanks.

Comment 7

[Tiffanie Shakespeare [:tif]]

Since this is getting a bit wonky, let's postpone the sound piece for the next release.

So for this release let's completely remove the sound during the self-timer countdown. Seem good?

Comment 8

[Youngjun Kim]

Dear Hema,

Please conclude this issue.

Comment 9

[Hema Koka [:hema]]

Yes we decided to simplify it for 1.4 release by removing the sound as Tif mentioned (The sound pieces will come later on master which will be 1.5 release)

Comment 10

[Youngjun Kim]

Ashish will upload the patch to remove the sound.

Comment 11

[David Flanagan [:djf]]

the patch that is already attached to this bug has landed on master and been uplifted to v1.4. This bug needs to be closed now. 

I have filed a followup bug in 991808 and have assigned it to Ashish.

Comment 12

[David Flanagan [:djf]]

Bulk edit for camera bugs.

If earlier comments do not show how this bug landed to master, it probably landed as part of https://github.com/mozilla-b2g/gaia/pull/17599 which merged the camera-new-features branch into master.

This bug was uplifted from master to v1.4 as part of https://github.com/mozilla-b2g/gaia/commit/a8190d08e61316a86bba572ba8d894d081a20530

Comment 13

[Wilson Page [:wilsonpage]]

AFAIK this is not resolved.

Comment 14

[Tiffanie Shakespeare [:tif]]

I think what David is saying is that since the patch has already been moved to master, we have to have a new bug for it which is 991808?

Comment 15

[Wilson Page [:wilsonpage]]

Agreed. Closing.

Comment 16

[sarsenyev]

Closing this per bug 991808, the sound is removed for this release.

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140411000202
Gaia: 6c50349f41d40ba175ea0fc0c2c2cbd739ba7170
Gecko: 28b419f0e857
Version: 30.0a2
Firmware Version: v1.2-device.cfg

1.5 Environmental Variables:
Device: Buri 1.5 Master
BuildID: 20140411040203
Gaia: 1368d716072adf308e1b435ac828f97545a045f1
Gecko: d8c1b10c3a3d
Version: 31.0a1
Firmware Version: v1.2-device.cfg