Closed
Bug 984897
Opened 11 years ago
Closed 11 years ago
Pressing on the edge of the screen misbehaves for HiDPI screens
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
Tracking | Status | |
---|---|---|
b2g-v2.0 | --- | fixed |
People
(Reporter: rik, Assigned: vingtetun)
References
Details
(Keywords: regression, Whiteboard: [systemsfe])
Attachments
(1 file)
1.71 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
STR on a Peak with edge gestures activated:
1) Go to Settings>Display
2) Tap the checkbox for Adjust automatically
Actual:
It opens the wallpaper selection menu
Expected:
Adjust automatically is toggled
If you disable edge gestures, it works as expected. If you tap the adjust automatically line, it works as expected.
Reporter | ||
Comment 1•11 years ago
|
||
It also prevents index scrolling on the alphabet in the Contacts app.
Reporter | ||
Comment 2•11 years ago
|
||
I believe this is also making the send button in the SMS app very hard to tap when the keyboard is opened.
Blocks: 991849
Summary: Pressing checkboxes on the edge of the screen misbehaves → Pressing checkboxes on the edge of the screen misbehaves for HiDPI screens
Updated•11 years ago
|
feature-b2g: --- → 2.0
Comment 3•11 years ago
|
||
Can we get a video showing the bug here on the latest trunk?
Keywords: qawanted
Reporter | ||
Comment 4•11 years ago
|
||
For QA, this only happens on hidpi devices. (I updated the title a bit late)
Comment 6•11 years ago
|
||
Dupe clarifies this is happening on our reference implementation.
blocking-b2g: --- → 2.0?
Keywords: qawanted → regression
Comment 7•11 years ago
|
||
Also - this is not a feature implementation piece, this is classified as a regression from turning on edge gestures.
feature-b2g: 2.0 → ---
Updated•11 years ago
|
Whiteboard: [systemsfe]
Updated•11 years ago
|
Component: Gaia → Gaia::System::Window Mgmt
Comment 8•11 years ago
|
||
IIRC this is a APZC issue, we might even have a dup.
Component: Gaia::System::Window Mgmt → Panning and Zooming
Product: Firefox OS → Core
Comment 9•11 years ago
|
||
Component: Panning and Zooming → Gaia::System::Window Mgmt
Product: Core → Firefox OS
Updated•11 years ago
|
Summary: Pressing checkboxes on the edge of the screen misbehaves for HiDPI screens → Pressing on the edge of the screen misbehaves for HiDPI screens
Comment 12•11 years ago
|
||
Any ETA for this? Zoom, On screen UI and touch to focus are affected by this in the camera app.
Comment 13•11 years ago
|
||
Hi Gregor, it belongs to system fe, can you do the triage?
Flags: needinfo?(anygregor)
Assignee | ||
Comment 14•11 years ago
|
||
I didn't tried the patch but Etienne told me that it fix the issue for him on the Nexus 4.
Attachment #8428764 -
Flags: review?(bugmail.mozilla)
Comment 15•11 years ago
|
||
Comment on attachment 8428764 [details] [diff] [review]
fix.injecttouchevent.patch
Review of attachment 8428764 [details] [diff] [review]:
-----------------------------------------------------------------
My only concern is that some marionette tests might be using this function on HiDPI devices, and might break because of this change. We should keep an eye out for any Marionette failures after this lands.
::: dom/ipc/TabParent.cpp
@@ +2003,5 @@
> + nsIDocument* doc = content->OwnerDoc();
> + if (!doc || !doc->GetShell()) {
> + return NS_ERROR_FAILURE;
> + }
> + nsPresContext* presContext = doc->GetShell()->GetPresContext();
Eventually we should refactor this boilerplate into a helper method. But no need to do that in this patch if you don't want to.
@@ +2009,3 @@
> event.touches.SetCapacity(aCount);
> for (uint32_t i = 0; i < aCount; ++i) {
> + LayoutDeviceIntPoint pt =
nit: trailing whitespace
Attachment #8428764 -
Flags: review?(bugmail.mozilla) → review+
Updated•11 years ago
|
blocking-b2g: 2.0? → 2.0+
Flags: needinfo?(anygregor)
Comment 17•11 years ago
|
||
I'll push this (with nit fixed) as soon as the tree reopens.
Comment 18•11 years ago
|
||
Pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/d0cd763cc5e8
Updated•11 years ago
|
Component: Gaia::System::Window Mgmt → IPC
Product: Firefox OS → Core
Version: unspecified → Trunk
Comment 21•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Updated•11 years ago
|
Assignee: nobody → 21
status-b2g-v2.0:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•