Adjust TB's theme for Windows 8 and up

RESOLVED FIXED in Thunderbird 31.0

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 31.0
x86_64
Windows 8

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(8 attachments, 16 obsolete attachments)

100.24 KB, image/png
Details
13.95 KB, image/png
Details
28.43 KB, patch
jsbruner
: review+
Paenglab
: ui-review+
Details | Diff | Splinter Review
14.45 KB, patch
Paenglab
: review+
Paenglab
: ui-review+
Details | Diff | Splinter Review
19.70 KB, patch
Paenglab
: review+
Paenglab
: ui-review+
Details | Diff | Splinter Review
7.01 KB, patch
Paenglab
: review+
Paenglab
: ui-review+
Details | Diff | Splinter Review
36.54 KB, image/png
Details
12.93 KB, patch
Paenglab
: review+
Paenglab
: ui-review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
This bug is to implement bug 960517 for TB
(Assignee)

Comment 1

5 years ago
Posted patch Part1: Win8-mainWindow.patch (obsolete) β€” β€” Splinter Review
This is the biggest patch for the main window. It styles the tabs, the toolbar with the buttons and the trees.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8392955 - Flags: ui-review?(mconley)
Attachment #8392955 - Flags: review?(mconley)
(Assignee)

Comment 2

5 years ago
Posted patch Part2: Win8-messageHeaders.patch (obsolete) β€” β€” Splinter Review
This patch styles the messageheader buttons and the attachment list.
Attachment #8392957 - Flags: ui-review?(mconley)
Attachment #8392957 - Flags: review?(mconley)
(Assignee)

Comment 3

5 years ago
Posted patch Part3: Win8-AB.patch (obsolete) β€” β€” Splinter Review
This is more or less a copy of the main patch adapted to the Addressbook.
Attachment #8392959 - Flags: ui-review?(mconley)
Attachment #8392959 - Flags: review?(mconley)
(Assignee)

Comment 4

5 years ago
Posted patch Part4: Win8-composer.patch (obsolete) β€” β€” Splinter Review
This is more or less a copy of the main patch adapted to the Compozer. I included the addressbook sidebar part in this patch because it is only visible in compozer.
Attachment #8392960 - Flags: ui-review?(mconley)
Attachment #8392960 - Flags: review?(mconley)
(Assignee)

Comment 5

5 years ago
The main difference to bug 960517 is, I used @media (-moz-windows-default-theme) and (-moz-os-version: windows-win8) to style the Win8 part because FX uses the same styling for Win7 Basic and Win8 themes. TB uses for Basic themes the native button/menulist appearance for better readability on High Contrast themes.

Part5 with the Chat adjustments follows a bit later.
(Assignee)

Comment 6

5 years ago
Posted patch Part5: Win8-chat.patch (obsolete) β€” β€” Splinter Review
This patch styles the chat tab content. I've added also some preprocessor code to include the MPL header only one time.

Florian, I added you only with f? because I don't know if you have a Win8 box.
Attachment #8393055 - Flags: ui-review?(mconley)
Attachment #8393055 - Flags: review?(mconley)
Attachment #8393055 - Flags: feedback?(florian)
Comment on attachment 8393055 [details] [diff] [review]
Part5: Win8-chat.patch

I don't, but clokep does.
Attachment #8393055 - Flags: feedback?(florian)
(Assignee)

Updated

5 years ago
Attachment #8393055 - Flags: feedback?(clokep)
(Assignee)

Comment 8

5 years ago
Posted patch Part1: Win8-mainWindow.patch (obsolete) β€” β€” Splinter Review
Oops, found a trailing whitespace.
Attachment #8392955 - Attachment is obsolete: true
Attachment #8392955 - Flags: ui-review?(mconley)
Attachment #8392955 - Flags: review?(mconley)
Attachment #8393074 - Flags: ui-review?(mconley)
Attachment #8393074 - Flags: review?(mconley)
(Assignee)

Comment 9

5 years ago
Posted patch Part3: Win8-AB.patch (obsolete) β€” β€” Splinter Review
The same whitespace. This comes from copy-n-paste.
Attachment #8392959 - Attachment is obsolete: true
Attachment #8392959 - Flags: ui-review?(mconley)
Attachment #8392959 - Flags: review?(mconley)
Attachment #8393076 - Flags: ui-review?(mconley)
Attachment #8393076 - Flags: review?(mconley)
(Assignee)

Comment 10

5 years ago
Posted patch Part4: Win8-composer.patch (obsolete) β€” β€” Splinter Review
Again whitespace. Sorry for the bug spam.
Attachment #8392960 - Attachment is obsolete: true
Attachment #8392960 - Flags: ui-review?(mconley)
Attachment #8392960 - Flags: review?(mconley)
Attachment #8393077 - Flags: ui-review?(mconley)
Attachment #8393077 - Flags: review?(mconley)
Comment on attachment 8393055 [details] [diff] [review]
Part5: Win8-chat.patch

I tested (the chat portion of) this on Windows 8.1 and it seems fine. Very blue-ish.
Attachment #8393055 - Flags: feedback?(clokep) → feedback+
Posted image Chat screenshot β€”

Comment 13

5 years ago
looks good!
(Assignee)

Comment 14

5 years ago
Posted patch Part1: Win8-mainWindow.patch (obsolete) β€” β€” Splinter Review
Fixed some Win8 High Contrast issues:
- Search boxes where not readable (see Fx bug 986324)
- Menu background in titlebar was black.
- I needed to use the Australis toolbarbutton styling also in HC because the buttons where black holes in toolbars gradient (on dark HC themes). I can't remove the gradient because it's needed for the tabs.
Attachment #8393074 - Attachment is obsolete: true
Attachment #8393074 - Flags: ui-review?(mconley)
Attachment #8393074 - Flags: review?(mconley)
Attachment #8402208 - Flags: ui-review?(mconley)
Attachment #8402208 - Flags: review?(mconley)
(Assignee)

Comment 15

5 years ago
Posted patch Part2: Win8-messageHeaders.patch (obsolete) β€” β€” Splinter Review
Fixed some Win8 High Contrast issues:
- #msgHeaderView had background-color: #f8f8f8 also on dark HC themes.
Attachment #8392957 - Attachment is obsolete: true
Attachment #8392957 - Flags: ui-review?(mconley)
Attachment #8392957 - Flags: review?(mconley)
Attachment #8402209 - Flags: ui-review?(mconley)
Attachment #8402209 - Flags: review?(mconley)
(Assignee)

Comment 16

5 years ago
Posted patch Part3: Win8-AB.patch (obsolete) β€” β€” Splinter Review
Fixed some Win8 High Contrast issues:
- Search boxes where not readable (see Fx bug 986324)
- Removed the toolbar gradient on HC themes.
Attachment #8393076 - Attachment is obsolete: true
Attachment #8393076 - Flags: ui-review?(mconley)
Attachment #8393076 - Flags: review?(mconley)
Attachment #8402210 - Flags: ui-review?(mconley)
Attachment #8402210 - Flags: review?(mconley)
(Assignee)

Comment 17

5 years ago
Posted patch Part4: Win8-composer.patch (obsolete) β€” β€” Splinter Review
Fixed some Win8 High Contrast issues:
- Search boxes where not readable (see Fx bug 986324)
- Removed the toolbar gradient on HC themes.
Attachment #8393077 - Attachment is obsolete: true
Attachment #8393077 - Flags: ui-review?(mconley)
Attachment #8393077 - Flags: review?(mconley)
Attachment #8402211 - Flags: ui-review?(mconley)
Attachment #8402211 - Flags: review?(mconley)
(Assignee)

Comment 18

5 years ago
Posted patch Part1: Win8-mainWindow.patch (obsolete) β€” β€” Splinter Review
Sorry to spam this bug but this patch needed a update to tip.
Attachment #8402208 - Attachment is obsolete: true
Attachment #8402208 - Flags: ui-review?(mconley)
Attachment #8402208 - Flags: review?(mconley)
Attachment #8402276 - Flags: ui-review?(mconley)
Attachment #8402276 - Flags: review?(mconley)
Comment on attachment 8402276 [details] [diff] [review]
Part1: Win8-mainWindow.patch

Redirecting to JosiahOne, because I've got zero time right now. :/
Attachment #8402276 - Flags: ui-review?(mconley)
Attachment #8402276 - Flags: ui-review?(josiah)
Attachment #8402276 - Flags: review?(mconley)
Attachment #8402276 - Flags: review?(josiah)
Attachment #8402209 - Flags: ui-review?(mconley)
Attachment #8402209 - Flags: ui-review?(josiah)
Attachment #8402209 - Flags: review?(mconley)
Attachment #8402209 - Flags: review?(josiah)
Comment on attachment 8402276 [details] [diff] [review]
Part1: Win8-mainWindow.patch

Actually, I might be able to take some of the UI reviews, once my build is done.
Attachment #8402276 - Flags: ui-review?(josiah) → ui-review?(mconley)
Attachment #8402209 - Flags: ui-review?(josiah) → ui-review?(mconley)
Attachment #8402210 - Flags: review?(mconley) → review?(josiah)
Attachment #8402211 - Flags: review?(mconley) → review?(josiah)
Attachment #8393055 - Flags: review?(mconley) → review?(josiah)
Just noting that it might take a while before I get to this. I have a Win 8 VM setup, but have been unable to get any builds to complete successfully.
(In reply to Josiah Bruner [:JosiahOne] from comment #21)
> Just noting that it might take a while before I get to this. I have a Win 8
> VM setup, but have been unable to get any builds to complete successfully.

A try push might be your best bet.
(Assignee)

Comment 24

5 years ago
Posted patch Part1: Win8-mainWindow.patch (obsolete) β€” β€” Splinter Review
Part1 was bitrotted by bug 995747.
Attachment #8402276 - Attachment is obsolete: true
Attachment #8402276 - Flags: ui-review?(mconley)
Attachment #8402276 - Flags: review?(josiah)
Attachment #8411135 - Flags: ui-review?(mconley)
Attachment #8411135 - Flags: review?(josiah)
Comment on attachment 8411135 [details] [diff] [review]
Part1: Win8-mainWindow.patch

Review of attachment 8411135 [details] [diff] [review]:
-----------------------------------------------------------------

In general I like this a lot, but here are some of the major issues:

- Main Toolbar button's active state cuts of borders, we should keep the borders.
- White lines under items in the folderpane. There seems to be some white lines that appear under some entries in the folder pane that aren't selected/hovered. It may be a drawing issue, but we could probably work around that by changing one of the parent's background color to match the entries.
- Message header buttons don’t have enough padding-right.
- Message header is blue when opened in a tab (intentional?)

I'll attach screenshots of all these problems.

Those are just general problems and not directed specifically at this patch. Review of the actual patch is below, just minor nits, so I'd give a r+ except for the major problems. So r-.

(I'm r- only to remind me that things to need be addressed, even if most of the issues don't revolve around this patch)

::: mail/themes/windows/mail/mailWindow1-aero.css
@@ +244,5 @@
> +}
> +
> +@media (-moz-windows-default-theme) and (-moz-os-version: windows-vista),
> +       (-moz-windows-default-theme) and (-moz-os-version: windows-win7) {
> +  /* < Win8 */

I don't think this comment is necessary. The @media query explains it well enough.

@@ +287,3 @@
>  
> +@media (-moz-windows-default-theme) and (-moz-os-version: windows-win8) {
> +  /* >= Win8 */

Ditto.

@@ +345,4 @@
>  
> +@media (-moz-windows-default-theme) and (-moz-os-version: windows-vista),
> +       (-moz-windows-default-theme) and (-moz-os-version: windows-win7) {
> +  /* < Win8 */

Ditto.

::: mail/themes/windows/mail/primaryToolbar-aero.css
@@ +67,5 @@
>  }
>  
> +@media (-moz-windows-default-theme) and (-moz-os-version: windows-vista),
> +       (-moz-windows-default-theme) and (-moz-os-version: windows-win7) {
> +  /* < Win8 */

Remove the comment.

@@ +106,5 @@
> +}
> +
> +@media (-moz-windows-default-theme) and (-moz-os-version: windows-vista),
> +       (-moz-windows-default-theme) and (-moz-os-version: windows-win7) {
> +  /* < Win8 */

Ditto.

@@ +190,5 @@
>    }
> +}
> +
> +@media (-moz-os-version: windows-win8) {
> +  /* >= Win8 */

Ditto.

@@ +248,5 @@
> +
> +@media (-moz-windows-default-theme) {
> +  /* Separator between menu and split type buttons */
> +  .toolbarbutton-1:not(:hover):not(:active):not([open]):not([checked])
> +   > .toolbarbutton-menubutton-dropmarker::before {

This makes the separator hide when hovering over it when disabled. You need to do what I did here: https://bug995681.bugzilla.mozilla.org/attachment.cgi?id=8405824

::: mail/themes/windows/mail/quickFilterBar-aero.css
@@ +2,3 @@
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>   

Trailing whitespace. Could you remove this?

@@ +38,5 @@
>  }
>  
> +@media (-moz-windows-default-theme) and (-moz-os-version: windows-vista),
> +       (-moz-windows-default-theme) and (-moz-os-version: windows-win7) {
> +  /* < Win8 */

Unneeded comment.

@@ +71,5 @@
>  }
>  
> +@media (-moz-os-version: windows-vista),
> +       (-moz-os-version: windows-win7) {
> +  /* < Win8 */

Ditto.

@@ +99,5 @@
>  }
>  
> +@media (-moz-windows-default-theme) and (-moz-os-version: windows-vista),
> +       (-moz-windows-default-theme) and (-moz-os-version: windows-win7) {
> +  /* < Win8 */

Ditto.

::: mail/themes/windows/mail/tabmail-aero.css
@@ +53,5 @@
>  }
>  
> +@media (-moz-windows-default-theme) and (-moz-os-version: windows-vista),
> +       (-moz-windows-default-theme) and (-moz-os-version: windows-win7) {
> +  /* < Win8 */

Remove comment.
Attachment #8411135 - Flags: ui-review?(mconley)
Attachment #8411135 - Flags: ui-review+
Attachment #8411135 - Flags: review?(josiah)
Attachment #8411135 - Flags: review-
Comment on attachment 8402211 [details] [diff] [review]
Part4: Win8-composer.patch

Review of attachment 8402211 [details] [diff] [review]:
-----------------------------------------------------------------

I really like this, just one UI-related thing, when you press down on the format toolbar buttons, the icon shifts over down and right quite a bit. It shouldn't. r+ with that fixed.

::: mail/themes/windows/mail/addrbook/abContactsPanel-aero.css
@@ +5,5 @@
>  %include abContactsPanel.css
>  
> +@media (-moz-windows-default-theme) and (-moz-os-version: windows-vista),
> +       (-moz-windows-default-theme) and (-moz-os-version: windows-win7) {
> +  /* < Win8 */

Comment again.

@@ +36,5 @@
> +}
> +
> +@media (-moz-windows-default-theme) and (-moz-os-version: windows-vista),
> +       (-moz-windows-default-theme) and (-moz-os-version: windows-win7) {
> +  /* < Win8 */

Comment.

@@ +79,3 @@
>  
> +@media (-moz-windows-default-theme) and (-moz-os-version: windows-win8) {
> +  /* >= Win8 */

Comment.

::: mail/themes/windows/mail/compose/messengercompose-aero.css
@@ +45,5 @@
>  }
>  
> +@media (-moz-os-version: windows-vista),
> +        (-moz-os-version: windows-win7) {
> +  /* < Win8 */

Comment again.

@@ +54,5 @@
> +}
> +
> +@media (-moz-windows-default-theme) and (-moz-os-version: windows-vista),
> +       (-moz-windows-default-theme) and (-moz-os-version: windows-win7) {
> +  /* < Win8 with default theme */

Ditto.

@@ +138,5 @@
>  }
>  
> +@media (-moz-windows-default-theme) and (-moz-os-version: windows-vista),
> +       (-moz-windows-default-theme) and (-moz-os-version: windows-win7) {
> +  /* < Win8 */

Ditto.

@@ +239,5 @@
>    }
>  }
>  
> +@media (-moz-windows-default-theme) and (-moz-os-version: windows-win8) {
> +  /* >= Win8 */

Ditto.

@@ +256,5 @@
> +  .toolbarbutton-1:not([disabled=true]):-moz-any(:hover,[open]) >
> +  .toolbarbutton-menubutton-dropmarker,
> +  .toolbarbutton-1:not([disabled=true]):not([checked=true]):not([open]):not(:active):hover,
> +  .toolbarbutton-1:not([buttonover]):not([open]):not(:active):hover >
> +  .toolbarbutton-menubutton-dropmarker:not([disabled]) {

Note to self: This is super ugly, fix it with JS attributes.

@@ +307,5 @@
> +
> +@media (-moz-windows-default-theme) {
> +  /* Separator between menu and split type buttons */
> +  .toolbarbutton-1:not(:hover):not(:active):not([open]):not([checked])
> +   > .toolbarbutton-menubutton-dropmarker::before {

Same thing as the other patch. separator disappears on hover when disabled.

@@ +429,5 @@
>  }
>  
> +@media (-moz-windows-default-theme) and (-moz-os-version: windows-vista),
> +       (-moz-windows-default-theme) and (-moz-os-version: windows-win7) {
> +  /* < Win8 */

Comment.

@@ +741,5 @@
>  }
>  
> +@media (-moz-windows-default-theme) and (-moz-os-version: windows-vista),
> +       (-moz-windows-default-theme) and (-moz-os-version: windows-win7) {
> +  /* < Win8 */

Comment.

@@ +755,5 @@
> +  }
> +}
> +
> +@media (-moz-windows-default-theme) and (-moz-os-version: windows-win8) {
> +  /* >= Win8 */

Ditto.

@@ +1121,5 @@
>  }
>  
> +@media (-moz-windows-default-theme) and (-moz-os-version: windows-vista),
> +       (-moz-windows-default-theme) and (-moz-os-version: windows-win7) {
> +  /* < Win8 */

Ditto.
Attachment #8402211 - Flags: ui-review?(mconley)
Attachment #8402211 - Flags: ui-review+
Attachment #8402211 - Flags: review?(josiah)
Attachment #8402211 - Flags: review+
Comment on attachment 8402210 [details] [diff] [review]
Part3: Win8-AB.patch

Review of attachment 8402210 [details] [diff] [review]:
-----------------------------------------------------------------

Looks. r+ with the nits addressed.

::: mail/themes/windows/mail/addrbook/addressbook-aero.css
@@ +36,5 @@
>  }
>  
> +@media (-moz-os-version: windows-vista),
> +        (-moz-os-version: windows-win7) {
> +  /* < Win8 */

I'm not going to mention all of them this time, but please kill all these comment lines.

@@ +215,5 @@
> +
> +@media (-moz-windows-default-theme) {
> +  /* Separator between menu and split type buttons */
> +  .toolbarbutton-1:not(:hover):not(:active):not([open]):not([checked])
> +   > .toolbarbutton-menubutton-dropmarker::before {

Same thing as before with the hovered+disabled.
Attachment #8402210 - Flags: ui-review?(mconley)
Attachment #8402210 - Flags: ui-review+
Attachment #8402210 - Flags: review?(josiah)
Attachment #8402210 - Flags: review+
Comment on attachment 8402209 [details] [diff] [review]
Part2: Win8-messageHeaders.patch

Review of attachment 8402209 [details] [diff] [review]:
-----------------------------------------------------------------

Also looks good for the most part. Except the blue background when in a tab probably needs to be addressed in this patch.

::: mail/themes/windows/mail/attachmentList-aero.css
@@ +91,5 @@
> +}
> +
> +@media (-moz-windows-default-theme) and (-moz-os-version: windows-vista),
> +       (-moz-windows-default-theme) and (-moz-os-version: windows-win7) {
> +  /* < Win8 */

Comment again.

@@ +128,5 @@
>    }
>  }
> +
> +@media (-moz-windows-default-theme) and (-moz-os-version: windows-win8) {
> +  /* >= Win8 */

Ditto.

::: mail/themes/windows/mail/messageHeader-aero.css
@@ +142,5 @@
>  }
>  
> +@media (-moz-windows-default-theme) and (-moz-os-version: windows-vista),
> +       (-moz-windows-default-theme) and (-moz-os-version: windows-win7) {
> +  /* < Win8 */

Ditto.

@@ +217,5 @@
> +}
> +
> +@media (-moz-windows-default-theme) and (-moz-os-version: windows-vista),
> +       (-moz-windows-default-theme) and (-moz-os-version: windows-win7) {
> +  /* < Win8 */

Ditto

@@ +241,5 @@
>    }
>  }
>  
> +@media (-moz-windows-default-theme) and (-moz-os-version: windows-win8) {
> +  /* >= Win8 */

Ditto.
Attachment #8402209 - Flags: ui-review?(mconley)
Attachment #8402209 - Flags: ui-review+
Attachment #8402209 - Flags: review?(josiah)
Attachment #8402209 - Flags: review+
Comment on attachment 8393055 [details] [diff] [review]
Part5: Win8-chat.patch

Review of attachment 8393055 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thanks.

::: mail/themes/windows/mail/chat-aero.css
@@ +6,1 @@
>  %include chat.css

Blank line before the %include please.

@@ +172,5 @@
>  }
>  
> +@media (-moz-windows-default-theme) and (-moz-os-version: windows-vista),
> +       (-moz-windows-default-theme) and (-moz-os-version: windows-win7) {
> +  /* < Win8 */

Comment again. This is the only one I will mention, fix others as well please.

::: mail/themes/windows/mail/chat.css
@@ +6,1 @@
>  %include ../../../components/im/themes/chat.css

Blank line before the include.
Attachment #8393055 - Flags: ui-review?(mconley)
Attachment #8393055 - Flags: ui-review+
Attachment #8393055 - Flags: review?(josiah)
Attachment #8393055 - Flags: review+
(Assignee)

Comment 31

5 years ago
Addressed comments. Now with toolbarbutton styling like http://people.mozilla.org/~shorlander/mockups-interactive/australis-interactive-mockups/windows8.html
Attachment #8411135 - Attachment is obsolete: true
Attachment #8412934 - Flags: ui-review+
Attachment #8412934 - Flags: review?(josiah)
(Assignee)

Comment 32

5 years ago
Posted patch Part2: Win8-messageHeaders.patch (obsolete) β€” β€” Splinter Review
Addressed comments.
Attachment #8402209 - Attachment is obsolete: true
Attachment #8412935 - Flags: ui-review+
Attachment #8412935 - Flags: review+
(Assignee)

Comment 33

5 years ago
Posted patch Part3: Win8-AB.patch β€” β€” Splinter Review
Addressed comments.
Attachment #8402210 - Attachment is obsolete: true
Attachment #8412938 - Flags: ui-review+
Attachment #8412938 - Flags: review+
If you could throw a new Try Build together that would be great.
(Assignee)

Comment 35

5 years ago
Addressed comments.
Attachment #8402211 - Attachment is obsolete: true
Attachment #8412940 - Flags: ui-review+
Attachment #8412940 - Flags: review+
(Assignee)

Comment 36

5 years ago
Posted patch Part5: Win8-chat.patch β€” β€” Splinter Review
Addressed comments.
Attachment #8393055 - Attachment is obsolete: true
Attachment #8412941 - Flags: ui-review+
Attachment #8412941 - Flags: review+
(Assignee)

Comment 38

5 years ago
Posted patch Part2: Win8-messageHeaders.patch (obsolete) β€” β€” Splinter Review
Found a whitespace.
Attachment #8412935 - Attachment is obsolete: true
Attachment #8412966 - Flags: ui-review+
Attachment #8412966 - Flags: review+
Comment on attachment 8412934 [details] [diff] [review]
Part1: Win8-mainWindow.patch

Review of attachment 8412934 [details] [diff] [review]:
-----------------------------------------------------------------

Fantastic! Only one nit and you're good to land. In the message header the "Other Actions" button looks like it has WAY to much padding-right, though it actually doesn't. Because of the dropdown arrow, the text is not centered properly, which makes it look like we need to move it to the right.

On OS X, we only use the text (no dropdown arrow), I suggest we do the same here.

I'll attach a screenshot.
Attachment #8412934 - Flags: review?(josiah) → review+
(Assignee)

Comment 41

5 years ago
"Other Actions" padding improved.
Attachment #8412966 - Attachment is obsolete: true
Attachment #8413272 - Flags: ui-review+
Attachment #8413272 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.