986404 - disable fade-out of overlay scrollbars during reftest

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This follows up on bug 926292 comment 29; I also noticed the same thing while trying to enable more B2G tests, which I mentioned to mstange and he told me about the issue.

We should disable the fadeout of overlay scrollbars during reftest, because we can't guarantee taking reftest snapshots at the same point during the fade.

This fixes failures on both 10.9 (tests not yet enabled) and B2G.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Disable fade-out of overlay scrollbars during reftest

Comment 2

[Markus Stange [:mstange]]

Comment on attachment 8394704 [details] [diff] [review]
Disable fade-out of overlay scrollbars during reftest

You can also remove the line I added in layout/reftests/z-index/reftest.list that sets the pref for that specific directory.

Comment 3

[Stephen A Pohl [:spohl]]

FYI, I think an alternative to disabling the fade-out was to disable overlay scrollbars, but that appears to be blocked by bug 952613. Thought I'd mention it here just in case.

Comment 4

[Timothy Nikkel (:tnikkel)]

I think we definitely want to test _with_ overlay scroll bars, at least some of the time. There are issues that only come up with overlay scrollbars.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

So it turns out this doesn't appear to fix all the overlay scrollbar inconsistencies I was seeing.  See, for example, abs-pos/scrollframe-1.html in the B2G R1 in https://tbpl.mozilla.org/?tree=Try&rev=14dd3c4eec2e .  (The difference is most visible in the second R1.)

Or all 3 tests in the R5 run.

(But I think it did fix some of them, although maybe that's just random variation.)

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Oh, that's probably because I missed the comment in reftest-cmdline.js that said the edits need to be made in two places!

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/285dfafec8f6

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

also, green try run at https://tbpl.mozilla.org/?tree=Try&rev=e13c09b234ef

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Also landed one change that I had in bug 986409, but just realized belonged here instead:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb690596c4ae

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/285dfafec8f6
https://hg.mozilla.org/mozilla-central/rev/fb690596c4ae

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(And bug 986807 fixes the fact that these pref changes need to be made in more than one place.)