987024 - [Contacts] Can not make a call from Contacts with bug 980982 applied

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Askeing Yen[:askeing][:fyen]]

Attachment: No network connection

### ENV
Buri master build
Gaia      e6702f8786633bbbe27ee5cbc00a31f7e2f60a8f
Gecko     https://hg.mozilla.org/mozilla-central/rev/c3b840de1f7b
BuildID   20140323160202
Version   31.0a1
ro.build.version.incremental=eng.archermind.20131114.105818
ro.build.date=Thu Nov 14 10:58:33 CST 2013

### STR
1. launch Contacts app
2. add a contact item
3. tap contact to open the detail page
4. tap Mobile field to make a call

### Except
1. make a phone call

### Actual
1. there is a "No network connection" error message on screen

Comment 1

[Askeing Yen[:askeing][:fyen]]

Attachment: VID_0012.3gp

Comment 3

[Peter Bylenga [:PBylenga]]

Gaia-Gecko swap test revealed this was a Gaia issue and we were able to determine a regression window for B2G-Inbound on 3-21-2014.  Also supplied our Tinderbox regression window for error checking purposes.

Last working B2G-Inbound
v1.5 Environmental Variables:
Device: Buri Master v1.5 MOZ RIL
BuildID: 20140321163215
Gaia: a970a22cceab5537dae680b9a172468602d901c7
Gecko: 3dbd42a3977d
Version: 31.0a1
Firmware Version: V1.2-device.cfg

First Broken B2G-Inbound
v1.5 Environmental Variables:
Device: Buri Master v1.5 MOZ RIL
BuildID: 20140321164315
Gaia: b2545bf6eb976704b54d82cfc06b24f31fedee6a
Gecko: 5251c32761cb
Version: 31.0a1
Firmware Version: V1.2-device.cfg

Last Working Gaia / First Broken Gecko: Issue Does NOT reproduce
Gaia: a970a22cceab5537dae680b9a172468602d901c7
Gecko: 5251c32761cb

Last Working Gecko / First Broken Gaia: Issue DOES reproduce
Gaia: b2545bf6eb976704b54d82cfc06b24f31fedee6a
Gecko: 3dbd42a3977d

B2G-Inbound Pushlog:
https://github.com/mozilla-b2g/gaia/compare/a970a22cceab5537dae680b9a172468602d901c7...b2545bf6eb976704b54d82cfc06b24f31fedee6a

Tinderbox (m-c) Pushlog:
https://github.com/mozilla-b2g/gaia/compare/002cca258af8586859c6efb2dada2fcec36754a1...255a56ac67e5b28f1fc78307969cc83391c9652f

Comment 4

[Jason Smith [:jsmith]]

bug 980982 caused this.

Comment 5

[Jason Smith [:jsmith]]

Note - if bug 980982 gets a 1.4+, then this should be marked as a 1.4+ as well.

Comment 6

[Doug Sherk (:drs) (inactive)]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17537

This patch includes a new test that used to fail and now passes.

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8395791 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17537

LGTM, tested on the phone and working right.

Also asking a dialer peer to review this as this shared code could potentially affect this app.

Great work Dough!

Comment 8

[Jason Smith [:jsmith]]

Removing smoketest as the regressing patch was backed out.

If Etienne signs off on this, then we can reland the blocking bug here & with the bug fix here.

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Nominating since this is blocking a 1.4? that we believe will be a 1.4+ soon.

Comment 10

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8395791 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17537

Moving the review to Anthony since Etienne is on PTO for all of this week.

Comment 11

[David Scravaglieri [:scravag]]

Blocks a blocker

Comment 12

[Anthony Ricaud (:rik)]

Comment on attachment 8395791 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17537

r=me but please, land this as only one patch with a commit message mentioning bug 980982. (since it has been backed out)

Comment 13

[Doug Sherk (:drs) (inactive)]

https://github.com/mozilla-b2g/gaia/commit/ba44508bef17c55394e62fdf2e33181d8b6c8eaf

Comment 16

[Doug Sherk (:drs) (inactive)]

v1.4: https://github.com/mozilla-b2g/gaia/commit/fb8b2d12290f25087bd0df426d1cf4afc37f3877

Comment 17

[Doug Sherk (:drs) (inactive)]

Followup for linting error on v1.4: https://github.com/mozilla-b2g/gaia/commit/29ed37f475ecfd292722f8d9c918c817c6e57e9b