989333 - Some Flash widget no longer display images since Shumway 0.8.6

Status: RESOLVED INCOMPLETE

(Firefox Graveyard :: Shumway, defect, P4)

Description

[Masatoshi Kimura [:emk]]

For example,
http://ichizengogo.blog.fc2.com/blog-entry-43.html
Pixiv widget no longer displays images.

Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=53376ef850fc&tochange=4da3e21a0e5f

4f4f4b20efc7	Yury Delendik — Bug 962736 - Update Shumway to version 0.8.6. r=till

I can't do further bisect because I was unable to build Shumway locally.

Comment 1

[Masatoshi Kimura [:emk]]

Browser console shows that the image is loaded from the server. It's just not rendered.

Comment 2

[Till Schneidereit [:till]]

Thanks for the report. Filed a bug in the Shumway issue tracker: https://github.com/mozilla/shumway/issues/1236

Comment 3

[Till Schneidereit [:till]]

Since fixed.

Comment 4

[Masatoshi Kimura [:emk]]

Sorry, still don't work for me.

Comment 5

[Masatoshi Kimura [:emk]]

Tested on 36. I can't even load Shumway on Nightly.

Comment 6

[Till Schneidereit [:till]]

(In reply to Masatoshi Kimura [:emk] from comment #5)
> Tested on 36. I can't even load Shumway on Nightly.

Slightly more information would be nice. What do you mean by "can't even load"? What happens instead? Is this with a clean profile?

Comment 7

[Masatoshi Kimura [:emk]]

(In reply to Till Schneidereit [:till] from comment #6)
> (In reply to Masatoshi Kimura [:emk] from comment #5)
> > Tested on 36. I can't even load Shumway on Nightly.
> 
> Slightly more information would be nice. What do you mean by "can't even
> load"? What happens instead? Is this with a clean profile?

A click-to-play box is displayed as if Shumway is not installed at all. Clean profile didn't make any changes.

Comment 8

[Till Schneidereit [:till]]

(In reply to Masatoshi Kimura [:emk] from comment #7)
> A click-to-play box is displayed as if Shumway is not installed at all.
> Clean profile didn't make any changes.

And this is on Windows 8.1? Is Flash available in the browser? This is obviously not something that affects all installations, so more details would be nice.

Comment 9

[Masatoshi Kimura [:emk]]

(In reply to Till Schneidereit [:till] from comment #8)
> And this is on Windows 8.1?

Yes.

> Is Flash available in the browser?

No. I'm not installing the genuine Adobe Flash Player.

Comment 10

[Till Schneidereit [:till]]

(In reply to Masatoshi Kimura [:emk] from comment #9)
> No. I'm not installing the genuine Adobe Flash Player.

Ok, then I'm not sure how this works in your release build since the site all but certainly does a Flash check that we currently fail if Flash isn't enabled in the browser. See bug 867626. Once that is fixed, things should work on many more sites.

Comment 11

[Masatoshi Kimura [:emk]]

(In reply to Till Schneidereit [:till] from comment #10)
> Ok, then I'm not sure how this works in your release build since the site
> all but certainly does a Flash check that we currently fail if Flash isn't
> enabled in the browser. See bug 867626. Once that is fixed, things should
> work on many more sites.

But it shouldn't apply to the url on comment #0. It doesn't do any runtime-check.
I suspect you just see the url with the genuine Flash player.

Comment 12

[Till Schneidereit [:till]]

(In reply to Masatoshi Kimura [:emk] from comment #11)
> But it shouldn't apply to the url on comment #0. It doesn't do any
> runtime-check.
> I suspect you just see the url with the genuine Flash player.

No I don't, I see the red Shumway button in the top-right corner.

However, in the very latest builds of the Shumway extension, the images do in fact not get rendered anymore, because we have made our interpretation of crossdomain.xml much stricter so we don't load anything at all anymore from other domains if a crossdomain.xml file. I filed bug 1142774 for that.

Comment 13

[Chris Peterson [:cpeterson]]

Masatoshi, what is the value of your "shumway.disabled" and "shumway.swf.whitelist" prefs? Now that Shumway is enabled in Nightly but only for some Amazon and IMDb videos, the "shumway.swf.whitelist" should be changed to "*" (asterisk without quotes) if you would like to use the Shumway extension everywhere.

Comment 14

[Masatoshi Kimura [:emk]]

Thank you, setting "shumway.swf.whitelist" to "*" works. But the image does not still load.