Closed Bug 989719 Opened 6 years ago Closed 6 years ago

js error in WifiWorker when doing geolocation and WiFi is disabled

Categories

(Firefox OS Graveyard :: Wifi, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:1.4+, firefox29 wontfix, firefox30 fixed, firefox31 fixed, b2g-v1.4 fixed, b2g-v2.0 fixed)

RESOLVED FIXED
1.4 S5 (11apr)
blocking-b2g 1.4+
Tracking Status
firefox29 --- wontfix
firefox30 --- fixed
firefox31 --- fixed
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed

People

(Reporter: gerard-majax, Assigned: vchang)

References

Details

(Keywords: regression)

Attachments

(1 file)

On current Gecko running on Desire Z, I can't get a correct geolocation.
logcat shows: E/GeckoConsole( 1194): [JavaScript Error: "this is undefined" {file: "jar:file:///system/b2g/omni.ja!/components/WifiWorker.js" line: 2577}]

Data connection is enabled and working fine, WiFi is disabled.

STR:
 0. Open HERE Maps
 1. Allow for geolocation

Expected:
 Location shown is correct

Actual:
 Location is incorrect (Paris, 250km away)

Logcat shows no call to the underlying geolocation stack as it was doing previously:
I/Gecko   ( 1194): *** injecting location
I/Gecko   ( 1194): *** lat: 48.860000
I/Gecko   ( 1194): *** lon: 2.350000
I/Gecko   ( 1194): *** accuracy: 40000.000000
blocking-b2g: --- → 1.4?
Version: 30 Branch → Trunk
What build ID was this tested on? Was this tested with a build containing bug 986349?
(In reply to Jason Smith [:jsmith] from comment #1)
> What build ID was this tested on? Was this tested with a build containing
> bug 986349?

Ah - missed the part saying "current gecko." Okay, that's today's build, which should have bug 986349.
Might be a regression from bug 976452.

Leaving qawanted to confirm on Buri 1.4.
Blocks: 976452
Component: Geolocation → Wifi
Keywords: qawanted
Product: Core → Firefox OS
Version: Trunk → unspecified
(In reply to Jason Smith [:jsmith] from comment #1)
> What build ID was this tested on? Was this tested with a build containing
> bug 986349?

Yes.
adjusting and scoping this bug.
Summary: Geolocation broken when WiFi disabled → js error in WifiWorker when doing geolocation and WiFi is disabled
Assignee: nobody → vchang
Attached patch Patch v1.0Splinter Review
Attachment #8399198 - Flags: review?(chulee)
Comment on attachment 8399198 [details] [diff] [review]
Patch v1.0

Review of attachment 8399198 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch, Thanks!
Attachment #8399198 - Flags: review?(chulee) → review+
Blocked to test it, Geo-location doesn't work with on Buri device see bug 98481

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140331000202
Gaia: 4c3b2f57f4229c5f36f0d8fd399e65f4db88f104
Gecko: 3aaca223b673
Version: 30.0a2
Firmware Version: v1.2-device.cfg
Keywords: qawanted
(In reply to sarsenyev from comment #8)
> Blocked to test it, Geo-location doesn't work with on Buri device see bug
> 98481

This isn't right. You need to have a SIM on your device & be outdoors to get geolocation to work.
Keywords: qawanted
The bug reproduces on Buri 1.5 central
Geolocation shows incorrect location when WIFI is off

Also I followed steps in comment 9 (SIM card inserted and outdoor), but Geo-location doesn't work on 1.4 and 1.3,the error message notifies "Can't find your location"

1.5 Environmental Variables:
Device: Buri 1.5 MOZ
BuildID: 20140331040200
Gaia: 26839cb46f856d610b192f5655a8c38a6bfe0829
Gecko: d8e8f13bd4ae
Version: 31.0a1
Firmware Version: v1.2-device.cfg
Keywords: qawanted
blocking-b2g: 1.4? → 1.4+
https://hg.mozilla.org/mozilla-central/rev/32147c583973
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.