989719 - js error in WifiWorker when doing geolocation and WiFi is disabled

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[:gerard-majax]

On current Gecko running on Desire Z, I can't get a correct geolocation.
logcat shows: E/GeckoConsole( 1194): [JavaScript Error: "this is undefined" {file: "jar:file:///system/b2g/omni.ja!/components/WifiWorker.js" line: 2577}]

Data connection is enabled and working fine, WiFi is disabled.

STR:
 0. Open HERE Maps
 1. Allow for geolocation

Expected:
 Location shown is correct

Actual:
 Location is incorrect (Paris, 250km away)

Logcat shows no call to the underlying geolocation stack as it was doing previously:
I/Gecko   ( 1194): *** injecting location
I/Gecko   ( 1194): *** lat: 48.860000
I/Gecko   ( 1194): *** lon: 2.350000
I/Gecko   ( 1194): *** accuracy: 40000.000000

Comment 1

[Jason Smith [:jsmith]]

What build ID was this tested on? Was this tested with a build containing bug 986349?

Comment 2

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #1)
> What build ID was this tested on? Was this tested with a build containing
> bug 986349?

Ah - missed the part saying "current gecko." Okay, that's today's build, which should have bug 986349.

Comment 3

[Jason Smith [:jsmith]]

Might be a regression from bug 976452.

Leaving qawanted to confirm on Buri 1.4.

Comment 4

[:gerard-majax]

(In reply to Jason Smith [:jsmith] from comment #1)
> What build ID was this tested on? Was this tested with a build containing
> bug 986349?

Yes.

Comment 5

[Doug Turner (:dougt)]

adjusting and scoping this bug.

Comment 6

[Vincent Chang[:vchang][changyihsin]]

Attachment: Patch v1.0

Comment 7

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Comment on attachment 8399198 [details] [diff] [review]
Patch v1.0

Review of attachment 8399198 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch, Thanks!

Comment 8

[sarsenyev]

Blocked to test it, Geo-location doesn't work with on Buri device see bug 98481

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140331000202
Gaia: 4c3b2f57f4229c5f36f0d8fd399e65f4db88f104
Gecko: 3aaca223b673
Version: 30.0a2
Firmware Version: v1.2-device.cfg

Comment 9

[Jason Smith [:jsmith]]

(In reply to sarsenyev from comment #8)
> Blocked to test it, Geo-location doesn't work with on Buri device see bug
> 98481

This isn't right. You need to have a SIM on your device & be outdoors to get geolocation to work.

Comment 10

[sarsenyev]

The bug reproduces on Buri 1.5 central
Geolocation shows incorrect location when WIFI is off

Also I followed steps in comment 9 (SIM card inserted and outdoor), but Geo-location doesn't work on 1.4 and 1.3,the error message notifies "Can't find your location"

1.5 Environmental Variables:
Device: Buri 1.5 MOZ
BuildID: 20140331040200
Gaia: 26839cb46f856d610b192f5655a8c38a6bfe0829
Gecko: d8e8f13bd4ae
Version: 31.0a1
Firmware Version: v1.2-device.cfg

Comment 11

[Vincent Chang[:vchang][changyihsin]]

https://hg.mozilla.org/integration/b2g-inbound/rev/32147c583973

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/32147c583973

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/acdc21019fce