Closed Bug 989933 Opened 11 years ago Closed 11 years ago

Create green themed header [BB] for comms apps

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S5 (11apr)

People

(Reporter: arnau, Assigned: arnau)

References

Details

Attachments

(3 files, 2 obsolete files)

No description provided.
Depends on: 985995
QA Contact: arnau
Summary: Change header [BB] colors form comms apps → Create green themed header [BB] for comms apps
Assignee: nobody → arnau
QA Contact: arnau
Attached image after_patch.png (obsolete) —
Przemek, me and Vicky have been doing small changes over the current header, to make them more consistent with comms one, and using your shapes doc. Please let us know if this works for you :)
Attachment #8401396 - Flags: review?(pabratowski)
Attachment #8401396 - Flags: review?(pabratowski) → ui-review?(pabratowski)
Attached image after_patch.png (obsolete) —
Attachment #8401396 - Attachment is obsolete: true
Attachment #8401396 - Flags: ui-review?(pabratowski)
Attachment #8401805 - Flags: ui-review?(pabratowski)
Attached image after_patch.png
Attachment #8401805 - Attachment is obsolete: true
Attachment #8401805 - Flags: ui-review?(pabratowski)
Attachment #8402679 - Flags: ui-review?(pabratowski)
Comment on attachment 8402679 [details] after_patch.png Looks good.
Attachment #8402679 - Flags: ui-review?(pabratowski) → ui-review+
Comment on attachment 8401400 [details] [review] patch in github LGTM :)
Attachment #8401400 - Flags: review?(pivanov) → review+
Merged: 1c2d1e28c21db2aceb2c9978e4b9fdfc77b685a7
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S5 (11apr)
Miller: In bug 972871 comment 3, you mentioned that SVG uses twice the memory of icon fonts. I'm interested in the comparison between optimized PNGs and the equivalent SVGs. Do you still have the test methodology around so I can compare?
Flags: needinfo?(mmedeiros)
Hi Anthony, I created a test file with 2 icons repeated 200 times each and just used the https://github.com/mozilla-b2g/B2G/blob/master/tools/get_about_memory.py to get the memory dump. I don't remind what was the memory difference between using SVG and PNG as a background-image. My test was more to check if inline SVG used more performance than icon fonts (which is true since SVG is part of the DOM). - for my use case background-images was not an option since I had to change colors dynamically. this might be a good patch to compare the memory usage between images and SVG.
Flags: needinfo?(mmedeiros)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: