Closed
Bug 989933
Opened 11 years ago
Closed 11 years ago
Create green themed header [BB] for comms apps
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.4 S5 (11apr)
People
(Reporter: arnau, Assigned: arnau)
References
Details
Attachments
(3 files, 2 obsolete files)
No description provided.
Updated•11 years ago
|
Summary: Change header [BB] colors form comms apps → Create green themed header [BB] for comms apps
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → arnau
QA Contact: arnau
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Comment 2•11 years ago
|
||
Przemek, me and Vicky have been doing small changes over the current header, to make them more consistent with comms one, and using your shapes doc.
Please let us know if this works for you :)
Attachment #8401396 -
Flags: review?(pabratowski)
Assignee | ||
Comment 3•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Attachment #8401396 -
Flags: review?(pabratowski) → ui-review?(pabratowski)
Assignee | ||
Comment 4•11 years ago
|
||
Attachment #8401396 -
Attachment is obsolete: true
Attachment #8401396 -
Flags: ui-review?(pabratowski)
Attachment #8401805 -
Flags: ui-review?(pabratowski)
Assignee | ||
Comment 5•11 years ago
|
||
Attachment #8401805 -
Attachment is obsolete: true
Attachment #8401805 -
Flags: ui-review?(pabratowski)
Attachment #8402679 -
Flags: ui-review?(pabratowski)
Comment 6•11 years ago
|
||
Comment on attachment 8402679 [details]
after_patch.png
Looks good.
Attachment #8402679 -
Flags: ui-review?(pabratowski) → ui-review+
Assignee | ||
Updated•11 years ago
|
Attachment #8401400 -
Flags: review?(pivanov)
Comment 7•11 years ago
|
||
Comment on attachment 8401400 [details] [review]
patch in github
LGTM :)
Attachment #8401400 -
Flags: review?(pivanov) → review+
Assignee | ||
Comment 8•11 years ago
|
||
Merged: 1c2d1e28c21db2aceb2c9978e4b9fdfc77b685a7
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Target Milestone: --- → 1.4 S5 (11apr)
Comment 9•11 years ago
|
||
Miller: In bug 972871 comment 3, you mentioned that SVG uses twice the memory of icon fonts. I'm interested in the comparison between optimized PNGs and the equivalent SVGs. Do you still have the test methodology around so I can compare?
Flags: needinfo?(mmedeiros)
Comment 10•11 years ago
|
||
Hi Anthony, I created a test file with 2 icons repeated 200 times each and just used the https://github.com/mozilla-b2g/B2G/blob/master/tools/get_about_memory.py to get the memory dump. I don't remind what was the memory difference between using SVG and PNG as a background-image. My test was more to check if inline SVG used more performance than icon fonts (which is true since SVG is part of the DOM). - for my use case background-images was not an option since I had to change colors dynamically.
this might be a good patch to compare the memory usage between images and SVG.
Flags: needinfo?(mmedeiros)
Comment 11•11 years ago
|
||
Posted my findings at https://bugzilla.mozilla.org/show_bug.cgi?id=987061.
You need to log in
before you can comment on or make changes to this bug.
Description
•