990518 - [Messaging][Visual Refresh] Keyboard suggestions should update messaging composer layout.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Borja Salguero [:borjasalguero]]

With the new Visual refresh we need to update the composer with the following:
- Composer style should update with the requirements detailed in the link:
https://dl.dropboxusercontent.com/u/346211/FxOS/Messagin_Composer_Keyboard_Suggestion.png

- Composer should take the whole available space

This should be controlled via an observer to the setting related with 'keyboard suggestions' or other equivalent way.

Comment 1

[Joan Leon [:joan]]

Attachment: Messagin_Composer_Keyboard_Suggestion.png

I Attached image in the bug, because I deleted from Dropbox ;)

Comment 2

[Julien Wajsberg [:julienw]]

Really, I don't think we'll be able to do something different with/without word suggestions (or maybe we'll need to look at the keyboard settings, and it feels bad :( )

_but_ we should still be able to control the composer max-height using the "vh" unit (say: .4vh) that would be good enough and would adapt to all situations.

Plus a special case for the "composer" view.

Comment 3

[Joan Leon [:joan]]

If we have access to the settings to see, if the keyboard suggestion is active, just add a class

Comment 4

[Julien Wajsberg [:julienw]]

The problem is that even if the setting is active, the suggestion part of the keyboard is not always enabled, depending on where the focus is.

Comment 5

[Joan Leon [:joan]]

But "vh" refers to the height of the device, which does not change with or without "Word Suggestion".

Comment 6

[Julien Wajsberg [:julienw]]

vh is the height of the _viewport_, which changes because the SMS app is resized accordingly, depending on the keyboard size.

Comment 7

[Joan Leon [:joan]]

I see that in master is already fixed this bug o_O

Julien, if you can check this, and you close this patch for address the issue of vh in another bug.

Comment 8

[Julien Wajsberg [:julienw]]

Look at comment 0, the requirements are still not there.

BTW this bug was created as a follow-up to bug 949457.

Comment 9

[Noemí Freire (:noemi)]

Hi Julien,

It seems keyboard suggestion is already appearing as specified. Do you mind to use this bug for tracking that and open a new bug to cover the pending composer layout work if needed?.

Comment 10

[Julien Wajsberg [:julienw]]

Noemi, this bug is not to make the keyboard suggestion appear or not. See comment 0 more precisely :)

This bug is to:
* implement attachment 8419274 [details] (and I don't think it's really possible actually, or I miss something)
* have the composer take the available space as specified (which should be really possible).

Borja filed this bug when he removed the JS-based calculations for the max-height in bug 949457. The goal of this bug was to put the max-height back using CSS only.

I'm removing Joan as the assignee as I get he has a lot of work, so that someone can pick this up next sprint ;)

Comment 11

[Julien Wajsberg [:julienw]]

Filed bug 1015867 for the "composer take the available space" part.

Comment 12

[Julien Wajsberg [:julienw]]

Discussed with the team, implementing attachment 8419274 [details] is possible but takes some work for a small improvement, so we keep it out of the current sprint.

Comment 13

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: nice to have for 2.0

Comment 14

[Stephany Wilkes]

Flagging Wilfred and Victoria to ensure they know about and agree with triage decision to mark this nice to have for 2.0, in which case it would no longer be blocking the Comms refresh.

Comment 15

[Victoria Gerchinhoren [:vicky]]

It looks buggy but if it requires too much work, don't block the VR.

Comment 16

[Stephany Wilkes]

What is the latest status on this? Please let me know if this will make 2.0 or if we should backlog it for a later release, so we can close out the visual refresh for 2.0. Thanks!

Comment 17

[Julien Wajsberg [:julienw]]

Nope, this won't happen in 2.0.

Comment 18

[Julien Wajsberg [:julienw]]

Hey Zhenshuo, I'd like to know if you still want this for the SMS app. Thanks !

Comment 19

[Stephany Wilkes]

I don't think Zhenshuo worked on this, and she has left Mozilla as of Friday. Flagging Carrie to see if this is still desired for SMS.

Comment 20

[Julien Wajsberg [:julienw]]

This was a Visual Design request, not a UX request, that's why I flagged Zhenshuo on this. Who's doing the Visual Design for SMS now?

Comment 21

[GoodMike]

Ni? our UX designer Omega and Visual designer Carol for feedback. Thank you.

Comment 22

[GoodMike]

Julien, Fang is your partner on Visual for SMS : ) Since previous comments indicated that it won't be available in 2.0 , the space should be 5px and we will adding adding an attach button in the ui. ni? Fang to upload latest design and spec for verification. Thank you.

Comment 23

[Fang Shih [:fang]]

Attachment: Spec_SMS_Compose.png

Attached is the latest spec for SMS compose view. The space should both be 5px (0.5 rem) either with word suggestion or not, which is what I've seen in the current build already. Let me know if there is anything I didn't cover. Thanks!

Comment 24

[Julien Wajsberg [:julienw]]

Hey Fang,

Actually, I wa

Comment 25

[Julien Wajsberg [:julienw]]

Hey Fang,

Actually, I wanted to know what you want it to be in v2.1. Is the 5px space good for you, or do we want to update the space depending on the keyboard suggestion, as originally planned?

Comment 26

[Fang Shih [:fang]]

Hi Julien,

Thanks for confirming. 5px space is good, We don't want to update the space anymore. Let it stay the same. Thanks!

Comment 27

[Julien Wajsberg [:julienw]]

Then it's a WONTFIX.

THanks Fang !