991126 - Link Clicker UI: Pressing start multiple times causes multiple push requests

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Mark Banner (:standard8)]

STR:

1) Generate a link and open it in a tab or separate browser.
2) Click the start button multiple times (or double click, etc) before the call starts.

Expected results:

One conversation window is opened and the call starts.

Actual Results:

Multiple conversation windows are opened.

Comment 1

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: https://github.com/mozilla/loop-client/pull/13

This patch prevent multiple submissions of the call start form. It depends on Bug 988229 which patch should land first.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8401363 [details] [review]
https://github.com/mozilla/loop-client/pull/13

Giving this review to Standard8, since I took one of his.

It's not quite clear to me how to get github to generate the correct comparison so that the thing that needs reviewing doesn't include the stuff that's already been reviewed as part of bug 988299 (the current PR appears to include those changes).

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8401363 [details] [review]
https://github.com/mozilla/loop-client/pull/13

r=Standard8. Please squash the commits before landing.

Comment 4

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Landed on master https://github.com/mozilla/loop-client/commit/ee5bd383f1694552e6211bb28e6bcdcb207fe822

Comment 5

[Mark Banner (:standard8)]

https://hg.mozilla.org/projects/elm/rev/9f7dd6d84b31

Comment 6

[Mark Banner (:standard8)]

https://hg.mozilla.org/mozilla-central/rev/9f7dd6d84b31

Comment 7

[u279076]

It looks like this landed with tests. Does this need QA testing?

Comment 8

[u279076]

Verified fixed through recent smoketesting.