Currently we rely on alert() to display error messages to end user, we should probably reuse the Backbone notification system introduced for the desktop client.
Assignee: nobody → nperriault
This is the first step of the patch, introducing a new shared Notifier component. Next step is to update desktop code to use it as well.
After having a long discussion with dmose about this, we should just use the current NotificationListView as a notifier. I'll revamp the patch accordingly.
Updated patch for a shared notification system.
Attachment #8401171 - Flags: review?(standard8)
Attachment #8401171 - Flags: review?(standard8) → review?(dmose)
Comment on attachment 8401171 [details] [review] https://github.com/mozilla/loop-client/pull/11 r=dmose, conditional on a few things described in the PR.
Attachment #8401171 - Flags: review?(dmose) → review+
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Looks like this landed with tests. Does this need QA testing?
We'll focus on testing the individual notifications. Untracking for QE verification.
You need to log in before you can comment on or make changes to this bug.