Loop webapp should display proper notifications to end user

RESOLVED FIXED in mozilla33

Status

defect
P3
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: NiKo, Unassigned)

Tracking

unspecified
mozilla33
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Currently we rely on alert() to display error messages to end user, we should probably reuse the Backbone notification system introduced for the desktop client.
Assignee: nobody → nperriault
This is the first step of the patch, introducing a new shared Notifier component. Next step is to update desktop code to use it as well.
Attachment #8400618 - Flags: review?(standard8)
Blocks: 972024
No longer blocks: 979880
OS: Mac OS X → All
Hardware: x86 → All
Summary: Loop client should display proper notifications to end user → Loop webapp should display proper notifications to end user
After having a long discussion with dmose about this, we should just use the current NotificationListView as a notifier. I'll revamp the patch accordingly.
Attachment #8400618 - Attachment is obsolete: true
Attachment #8400618 - Flags: review?(standard8)
Priority: -- → P3
Updated patch for a shared notification system.
Attachment #8401171 - Flags: review?(standard8)
Blocks: 991129
Attachment #8401171 - Flags: review?(standard8) → review?(dmose)
Comment on attachment 8401171 [details] [review]
https://github.com/mozilla/loop-client/pull/11

r=dmose, conditional on a few things described in the PR.
Attachment #8401171 - Flags: review?(dmose) → review+
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Looks like this landed with tests. Does this need QA testing?
Whiteboard: [qa?]
We'll focus on testing the individual notifications. Untracking for QE verification.
Flags: qe-verify-
Whiteboard: [qa?]
You need to log in before you can comment on or make changes to this bug.