988229 - Loop webapp should display proper notifications to end user

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P3)

Description

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Currently we rely on alert() to display error messages to end user, we should probably reuse the Backbone notification system introduced for the desktop client.

Comment 1

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: https://github.com/mozilla/loop-client/pull/11

This is the first step of the patch, introducing a new shared Notifier component. Next step is to update desktop code to use it as well.

Comment 2

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

After having a long discussion with dmose about this, we should just use the current NotificationListView as a notifier. I'll revamp the patch accordingly.

Comment 3

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: https://github.com/mozilla/loop-client/pull/11

Updated patch for a shared notification system.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8401171 [details] [review]
https://github.com/mozilla/loop-client/pull/11

r=dmose, conditional on a few things described in the PR.

Comment 5

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Landed https://github.com/mozilla/loop-client/commit/60c1336fcf780a44fc82218f392c613f77cb30ae

Comment 6

[Mark Banner (:standard8)]

https://hg.mozilla.org/projects/elm/rev/d1b7f66f2be1

Comment 7

[Mark Banner (:standard8)]

https://hg.mozilla.org/mozilla-central/rev/d1b7f66f2be1

Comment 8

[u279076]

Looks like this landed with tests. Does this need QA testing?

Comment 9

[u279076]

We'll focus on testing the individual notifications. Untracking for QE verification.