991344 - [B2G][Contacts][Camera]Unable to attach image from camera to contact because camera never loads

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Ross Kuhlman ([e-mail])]

Attachment: ContactAttachCamera.txt

The user is unable to attach an image directly from the camera to a contact. After tapping the 'attach from camera' button, the screen will turn black. The camera UI never appears. This issue does not occur in the Email or Messaging apps.

Repro Steps:
1) Updated Buri to BuildID: 20140402040201
2) Launch Contacts app.
3) Create a new contact.
4) Tap on 'Add Picture'.
5) Select 'Camera'

Actual:
The screen turns black. Notification bar is still present and functional.

Expected:
Camera loads properly.

Environmental Variables:
Device: Buri (Master M-C) Moz RIL
BuildID: 20140402040201
Gaia: 6274b3645b3d41df4aa5a55398b5d106edf1c528
Gecko: 4941a2ac0786
Version: 31.0a1
Firmware Version: v1.2-device.cfg

Notes:

Repro frequency: 100%
See attached: logcat

Comment 1

[Marcia Knous [:marcia]]

This sounds like a dupe of Bug 988731, except it appears to not have been fixed on the Buri. Will investigate further.

Comment 2

[Hema Koka [:hema]]

I want to make sure this does not happen on 1.4 

rkuhlman or marcia: Could you please test there as well?

Comment 3

[Marcia Knous [:marcia]]

On Buri this still happens with 1.4 using:

Gaia   a8190d08e61316a86bba572ba8d894d081a20530
SourceStamp 8a3af98bb338
BuildID 20140403111119
Version 30.0a2

Happens on trunk as well.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Bebe, team, is this something we can reliably get in automation?

Comment 5

[Marcia Knous [:marcia]]

This bug occurs on the Nexus 4 as well using:

Gaia   b28750e4d59945615d02be4b41f8faf7642dde01
SourceStamp
BuildID 20140404023052
Version 31.0a1

Comment 6

[Florin Strugariu [:Bebe]]

Stephen we have something similar in test_add_photo_from_gallery_to_contact

https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/contacts/test_add_photo_to_contact.py

We could add a new test to use the camera app.

Comment 7

[Natalya Kot [:nkot]]

I'd like to clarify 1.4 reproducibility here.
This bug got introduced to 1.4 on 04/03 between 20140403000210 and 20140403111119 (also explains why it wasn't reported in 04/03 manual smoketest report for 1.4 )

Jason: would that be enough to find regression-window on 1.4 then, or we still need to find both, 1.4 and master RW

BuildID: 20140403000210 - Does NOT Reproduce
Gaia: e0186439b9c2c03acd78e9ae011a0071865e7ffb
Gecko: 5bccd264a0e3
Version: 30.0a2

BuildID: 20140403111119 - Reproduces
Gaia: a8190d08e61316a86bba572ba8d894d081a20530
Gecko: 8a3af98bb338
Version: 30.0a2

BuildID: 20140404000202 - Reproduces
Gaia: b4f3b84ec68233a99fd5865c15cfe28aebe26531
Gecko: 3186bbc50050
Version: 30.0a2

Comment 8

[Jason Smith [:jsmith]]

I'd prefer if the window was done on master, not 1.4.

Comment 9

[Harvey]

B2G Inbound Regression Window

Last Working
1.5 Environmental Variables:
Device: Buri 1.5 MOZ
BuildID: 20140326103839
Gaia: b3c98000d6424153dc4ea5fbab2c4c2876ac9412
Gecko: 3faf66dc140f
Version: 31.0a1
Firmware Version: v1.2-device.cfg

First Broken
1.5 Environmental Variables:
Device: Buri 1.5 MOZ
BuildID: 20140326113652
Gaia: e1c443d9ff62a21920d389be097d0e666f38e70b
Gecko: 999f90b84990
Version: 31.0a1
Firmware Version: v1.2-device.cfg

Last Working Gaia First Broken Gecko: Issue does NOT reproduce
Gaia: b3c98000d6424153dc4ea5fbab2c4c2876ac9412
Gecko: 999f90b84990

First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: e1c443d9ff62a21920d389be097d0e666f38e70b
Gecko: 3faf66dc140f

Gaia Pushlog:
https://github.com/mozilla-b2g/gaia/compare/b3c98000d6424153dc4ea5fbab2c4c2876ac9412...e1c443d9ff62a21920d389be097d0e666f38e70b

Comment 10

[Wilson Page [:wilsonpage]]

Reproducible on 'master'. Related to incoming activity logic:

[JavaScript Error: "types.forEach is not a function" {file: "app://camera.gaiamobile.org/js/main.js" line: 5210}]'

Comment 11

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Comment 12

[Justin D'Arcangelo [:justindarc]]

Wilson: This patch looks ok, but before R+ing it, would we be better off patching the Contacts app to initiate a proper 'pick' activity instead of handling this one case differently than the rest of the Gaia apps (including Browser)?

Comment 13

[Wilson Page [:wilsonpage]]

justindarc: Yeah if they are deviating from some kind of spec. Although this is breaking TBPL, I'm inclined to land the fix ASAP.

Comment 14

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8402008 [details] [review]
pull-request (master)

Let's submit a follow-up bug to fix the activity in the Contacts app as well. Go ahead and land this for now though.

Comment 15

[Wilson Page [:wilsonpage]]

Landed on 'master': https://github.com/mozilla-b2g/gaia/commit/1cdbdb70e7cf556f1c7e208a7a2c3e00d4acb203

Comment 16

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/55f0798927699712215f3ca129eae7a729a9c0d8

Comment 17

[Zac C (:zac)]

Florin I think that seems like a bit of an edge case.
If it's in the manual smoketest suite we can do it, otherwise not.

Comment 18

[Ross Kuhlman ([e-mail])]

There is a step in the test case that explicitly says:
'Add a Picture from Camera app (select Camera, and take a picture)'

link to test case: https://moztrap.mozilla.org/manage/case/1309/

Comment 19

[Brogan Zumwalt [Inactive]]

Issue does NOT occur on 1.4 or Master M-C

Verified fixed

Environmental Variables:
Device: Buri v1.4 Mozilla RIL
BuildID: 20140408000202
Gaia: 26983f356ecb1bcf30e862d334b5de790071803e
Gecko: 70b076fc7558
Version: 30.0a2
Firmware Version: v1.2-device.cfg

Device: Buri Master M-C Mozilla RIL
BuildID: 20140408040204
Gaia: 1958454595b1fa0e061f0652ae965629993f5708
Gecko: 8883360b1edb
Version: 31.0a1
Firmware Version: v1.2-device.cfg