991377 - [B2G][Browser] Favorite and share icons in wrapper are duplicated multiple times

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Brogan Zumwalt [Inactive]]

Attachment: Screenshot

Description:
In browser app favorite and share icons appear to have graphics issue where multiple copies of each icon appear next to each other in wrapper. Issue worsens if device is rotated to landscape mode.

Repro Steps:
1) Updated Buri to BuildID: 20140402040201
2) Launch Browser app
3) Navigate to any webpage

Actual:
Favorite and share icons on bottom wrapper are duplicated multiple times.

Expected:
One of each wrapper icon is displayed.

Environmental Variables:
Device: Buri Master M-C Mozilla RIL
BuildID: 20140402040201
Gaia: 6274b3645b3d41df4aa5a55398b5d106edf1c528
Gecko: 4941a2ac0786
Version: 31.0a1
Firmware Version: v1.2-device.cfg

Notes:
Repro frequency: 3/3, 100%
See attached: screenshot

Comment 1

[Jason Smith [:jsmith]]

Does this reproduce on 1.4?

Comment 2

[jcastro]

Bug does not occur on a Buri FFOS V1.4

1.4 Environmental Variables:
Device: buri 1.4 MOZ
BuildID: 20140402000202
Gaia: 1db7a4857faec427799de0827964128b445e80ea
Gecko: b1b159c885cc
Version: 30.0a2
Firmware Version: v1.2-device.cfg

Comment 5

[Brogan Zumwalt [Inactive]]

Unable to narrow regression window further due to being blocked by bug 989306

Florin's fix listed in comment number three works, but we do not have access to older Gaia via Git. 

Last Working Tinderbox Environmental Variables:
Device: Buri Master M-C Mozilla RIL
BuildID: 20140327061550
Gaia: 287195d1fed2e6c883745d7091a4c05e56c4dbb7
Gecko: bb4dd9872236
Version: 31.0a1
Firmware Version: v1.2-device.cfg

First Broken Tinderbox Environmental Variables:
Device: Buri Mozilla M-C Mozilla RIL
BuildID: 20140329091830
Gaia: 4cf7ec04b82320a1ff1f825220204f454f951a87
Gecko: 1d2a6c43e284
Version: 31.0a1
Firmware Version: v1.2-device.cfg

Comment 6

[Jason Smith [:jsmith]]

This is missing a push log & a gaia/gecko swap.

Comment 7

[Brogan Zumwalt [Inactive]]

Tinderbox Broken Gaia / Working Gecko - Issue DOES Reproduce
Gaia: 4cf7ec04b82320a1ff1f825220204f454f951a87
Gecko: bb4dd9872236

Tinderbox Working Gaia / Broken Gecko - Issue Does NOT Reproduce
Gaia: 287195d1fed2e6c883745d7091a4c05e56c4dbb7
Gecko: 1d2a6c43e284

Issue appears to be a Gaia issue

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/287195d1fed2e6c883745d7091a4c05e56c4dbb7...4cf7ec04b82320a1ff1f825220204f454f951a87

Comment 8

[Jason Smith [:jsmith]]

Might be caused by bug 969553.

Comment 9

[Dale Harvey (:daleharvey)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/18030

Comment 11

[Ben Francis [:benfrancis]]

Comment on attachment 8402618 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/18030

Thanks Dale

Comment 12

[Ben Francis [:benfrancis]]

Merged into master https://github.com/mozilla-b2g/gaia/commit/15a7077db651ef649b251176f12740aed5dd6f5f

Comment 13

[Jason Smith [:jsmith]]

(In reply to Ben Francis [:benfrancis] from comment #12)
> Merged into master
> https://github.com/mozilla-b2g/gaia/commit/
> 15a7077db651ef649b251176f12740aed5dd6f5f

Should this be closed?

Comment 14

[Ben Francis [:benfrancis]]

I guess so.